Skip to content

buffer: use a default offset #19749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 3 commits into from
Closed

buffer: use a default offset #19749

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
95449ef
buffer: use a default offset
BridgeAR Apr 2, 2018
12e344a
fixup: accept weird cases as well
BridgeAR Apr 10, 2018
b895a85
fixup
BridgeAR Apr 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup
  • Loading branch information
@BridgeAR
BridgeAR committed Apr 10, 2018
commit b895a85187c10a8b6af28b6d25c8519a7053b29b
6 changes: 4 additions & 2 deletions lib/internal/buffer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ const {
ERR_OUT_OF_RANGE
} = require('internal/errors').codes;
const { setupBufferJS } = binding;
const { endianness } = require('os');

// Remove from the binding so that function is only available as exported here.
// (That is, for internal use only.)
Expand All @@ -20,7 +19,10 @@ const float64Array = new Float64Array(1);
const uInt8Float64Array = new Uint8Array(float64Array.buffer);

// Check endianness.
const bigEndian = endianness === 'BE';
float32Array[0] = -1; // 0xBF800000
// Either it is [0, 0, 128, 191] or [191, 128, 0, 0]. It is not possible to
// check this with `os.endianness()` because that is determined at compile time.
const bigEndian = uInt8Float32Array[3] === 0;

function checkBounds(buf, offset, byteLength) {
checkNumberType(offset);
Expand Down