Skip to content

timers: enable timers to be used as primitives #19683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bmeck wants to merge 7 commits into from
Closed

timers: enable timers to be used as primitives #19683

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9ac2bd4
timers: enable timers to be used as primitives
bmeck Mar 29, 2018
6101d52
move cache assignment to toPrimitive call
bmeck Mar 29, 2018
e32b969
doc && fix bug
bmeck Mar 29, 2018
c4ec0e5
nits
bmeck Mar 29, 2018
d963047
nits
bmeck Mar 29, 2018
54b8894
only delete if put into cache
bmeck Mar 30, 2018
d7ae747
linting
bmeck Mar 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
move cache assignment to toPrimitive call
  • Loading branch information
@bmeck
bmeck committed Mar 29, 2018
commit 6101d5283ad9e565c87a365140fa4823825d0e91
5 changes: 3 additions & 2 deletions lib/timers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,6 @@ const KNOWN_TIMERS = Object.create(null);
// Schedule or re-schedule a timer.
// The item must have been enroll()'d first.
const active = exports.active = function(item) {
KNOWN_TIMERS[item[async_id_symbol]] = item;
insert(item, false);
};

Expand Down Expand Up @@ -537,7 +536,9 @@ function unrefdHandle(timer, now) {
}

Timeout.prototype[Symbol.toPrimitive] = function() {
Copy link
Copy Markdown
Member

@TimothyGu TimothyGu Mar 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why @@toPrimitive rather than valueOf?

Copy link
Copy Markdown
Member Author

@bmeck bmeck Mar 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see https://codepen.io/bradleymeck/pen/eMMpdR?editors=0012 , .valueOf is not safe for using as a key. toPrimitive handles both string and number coercion.

return this[async_id_symbol];
const id = this[async_id_symbol];
KNOWN_TIMERS[id] = this;
return id;
};

Timeout.prototype.unref = function() {
Expand Down