Skip to content

test: removed default message from assert.strictEqual #19660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jaspal-yupana wants to merge 1 commit into from
Closed

test: removed default message from assert.strictEqual #19660

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: removed default message from assert.strictEqual 
assert.strictEqual default should include a better output message.
  • Loading branch information
@jaspal-yupana
jaspal-yupana committed Mar 28, 2018
commit 5f4ccefbdb6f904dca391eb517d52c803b75333f
7 changes: 3 additions & 4 deletions test/parallel/test-net-server-pause-on-connect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ const server1ConnHandler = (socket) => {
assert.fail('data event should not have happened yet');
}

assert.strictEqual(data.toString(), msg, 'invalid data received');
assert.strictEqual(data.toString(), msg);
socket.end();
server1.close();
});
Expand All @@ -46,12 +46,11 @@ const server1 = net.createServer({ pauseOnConnect: true }, server1ConnHandler);

const server2ConnHandler = (socket) => {
socket.on('data', function(data) {
assert.strictEqual(data.toString(), msg, 'invalid data received');
assert.strictEqual(data.toString(), msg);
socket.end();
server2.close();

assert.strictEqual(server1Sock.bytesRead, 0,
'no data should have been read yet');
assert.strictEqual(server1Sock.bytesRead, 0);
server1Sock.resume();
stopped = false;
});
Expand Down