test: adding tests for fs/promises.js fileHandle methods

Working to increase test code coverage for fs/promises.js. Added tests for fileHandle.appendFile and fileHandle.chmod.
nodejs · willhayslett · Mar 26, 2018 · Mar 28, 2018 · Mar 30, 2018 · Apr 3, 2018
commit f98fc81653619cc1b5006014ab916aebd1811003
diff --git a/test/parallel/test-fs-promises-file-handle-append-file.js b/test/parallel/test-fs-promises-file-handle-append-file.js
@@ -0,0 +1,50 @@
+'use strict';
+
+const common = require('../common');
+
+// The following tests validate base functionality for the fs/promises
+// FileHandle.appendFile method.
+
+const fs = require('fs');
+const { open } = require('fs/promises');
+const path = require('path');
+const tmpdir = require('../common/tmpdir');
+const assert = require('assert');
+const tmpDir = tmpdir.path;
+
+async function validateAppendBuffer({ filePath,
+                                      fileHandle,
+                                      bufferToAppend }) {
+  await fileHandle.appendFile(bufferToAppend);
+  const appendedFileData = fs.readFileSync(filePath);
+  assert.deepStrictEqual(appendedFileData, bufferToAppend);
+}
+
+async function validateAppendString({ filePath,
+                                      fileHandle,
+                                      stringToAppend,
+                                      bufferToAppend }) {
+  await fileHandle.appendFile(stringToAppend);
+  const stringAsBuffer = Buffer.from(stringToAppend, 'utf8');
+  const appendedFileData = fs.readFileSync(filePath);
+  const combinedBuffer = Buffer.concat([bufferToAppend, stringAsBuffer]);
+  assert.deepStrictEqual(appendedFileData, combinedBuffer);
+}
+
+async function executeTests() {
+  tmpdir.refresh();
+  common.crashOnUnhandledRejection();
+
+  const filePath = path.resolve(tmpDir, 'tmp-append-file.txt');
+  const appendFileDetails = {
+    filePath,
+    fileHandle: await open(filePath, 'a'),
+    bufferToAppend: Buffer.from('a&Dp'.repeat(100), 'utf8'),
+    stringToAppend: 'x~yz'.repeat(100)
+  };
+
+  await validateAppendBuffer(appendFileDetails);
+  await validateAppendString(appendFileDetails);
+}
+
+executeTests().then(common.mustCall());
diff --git a/test/parallel/test-fs-promises-file-handle-chmod.js b/test/parallel/test-fs-promises-file-handle-chmod.js
@@ -0,0 +1,43 @@
+'use strict';
+
+const common = require('../common');
+
+// The following tests validate base functionality for the fs/promises
+// FileHandle.chmod method.
+
+const fs = require('fs');
+const { open } = require('fs/promises');
+const path = require('path');
+const tmpdir = require('../common/tmpdir');
+const assert = require('assert');
+const tmpDir = tmpdir.path;
+
+async function validateFilePermission({ filePath, fileHandle }) {
+  //file created with r/w, should not have execute
+  fs.access(filePath, fs.constants.X_OK, common.mustCall(async (err) => {
+    //err should an instance of Error
+    assert.deepStrictEqual(err instanceof Error, true);
+    //add execute permissions
+    await fileHandle.chmod(0o765);
+
+    fs.access(filePath, fs.constants.X_OK, common.mustCall((err) => {
+      //err should be undefined or null
+      assert.deepStrictEqual(!err, true);
+    }));
+  }));
+}
+
+async function executeTests() {
+  tmpdir.refresh();
+  common.crashOnUnhandledRejection();
+
+  const filePath = path.resolve(tmpDir, 'tmp-chmod.txt');
+  const chmodFileDetails = {
+    filePath,
+    fileHandle: await open(filePath, 'w+', 0o666)
+  };
+
+  await validateFilePermission(chmodFileDetails);
+}
+
+executeTests().then(common.mustCall());