doc: add 'v' prefix to all versions in metadata#19590
Closed
tniessen wants to merge 1 commit into
Closed
Conversation
targos
approved these changes
Mar 25, 2018
Member
Author
richardlau
approved these changes
Mar 25, 2018
BridgeAR
approved these changes
Mar 25, 2018
cjihrig
approved these changes
Mar 25, 2018
Contributor
|
New CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/330/ (something happens to CI-lite, it gets aborted too often lately) |
Contributor
Contributor
|
I give up) |
trivikr
approved these changes
Mar 25, 2018
Member
|
CI-lite which didn't abort 😉https://ci.nodejs.org/job/node-test-pull-request-lite/334/ |
Member
|
Landed in e821071 |
trivikr
pushed a commit
that referenced
this pull request
Mar 25, 2018
PR-URL: #19590 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Mar 27, 2018
PR-URL: #19590 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change version literals for consistency with the rest (9 vs 1661 occurrences).
Checklist