Skip to content

[v9.x backport] Various http2 changes #19579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
targos wants to merge 6 commits into from
Closed

[v9.x backport] Various http2 changes #19579

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b4a99a7
test: http2 errors on req.close()
trivikr Feb 18, 2018
b59f421
test: add more asserts to `test-internal-errors`
refack Jun 19, 2017
fd94671
test: fix common.expectsError
refack Jun 14, 2017
8e5fd45
test: fix wrong error classes passed in as type
BridgeAR Dec 11, 2017
c0a9336
test: http2 stream.respond() error checks
trivikr Feb 19, 2018
a6785dc
http2: refer to stream errors by name
addaleax Feb 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: fix common.expectsError 
The function should strictly test for the error class and only accept
the correct one. Any other error class should fail.

PR-URL: #13686
Fixes: #13682
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
  • Loading branch information
@refack @targos
refack authored and targos committed Mar 24, 2018
commit fd9467196f4be75a35fd278e9810fb0fe89db97f
5 changes: 5 additions & 0 deletions test/common/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,6 +689,11 @@ exports.expectsError = function expectsError(fn, settings, exact) {
}
assert(error instanceof type,
`${error.name} is not instance of ${type.name}`);
let typeName = error.constructor.name;
if (typeName === 'NodeError' && type.name !== 'NodeError') {
typeName = Object.getPrototypeOf(error.constructor).name;
}
assert.strictEqual(typeName, type.name);
}
if ('message' in settings) {
const message = settings.message;
Expand Down