Skip to content

test: remove optional third param from assert.strictEqual #19536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davisokoth wants to merge 1 commit into from
Closed

test: remove optional third param from assert.strictEqual #19536

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: remove optional third param from assert.strictEqual 
Removing third argument in calls to assert.strictEqual() so that the
values of the first two arguments are shown instead as this is more
useful for debugging

Refs: https://nodejs.org/api/assert.html#assert_assert_strictequal_actual_expected_message
  • Loading branch information
= committed Mar 22, 2018
commit 4555f557ce6a6c10e626a274c4b0fb4be1b86acb
4 changes: 2 additions & 2 deletions test/parallel/test-fs-mkdir-rmdir.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ fs.mkdir(d, 0o666, common.mustCall(function(err) {
assert.strictEqual(this, undefined);
assert.ok(err, 'got no error');
assert.ok(/^EEXIST/.test(err.message), 'got no EEXIST message');
assert.strictEqual(err.code, 'EEXIST', 'got no EEXIST code');
assert.strictEqual(err.path, d, 'got no proper path for EEXIST');
assert.strictEqual(err.code, 'EEXIST');
assert.strictEqual(err.path, d);

fs.rmdir(d, assert.ifError);
}));
Expand Down