Skip to content

[8.x] Backport 18513, 18694 #19517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ofrobots merged 3 commits into from
Jun 28, 2018
Merged

[8.x] Backport 18513, 18694 #19517

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e2b3807
async_hooks: deprecate unsafe emit{Before,After}
ofrobots Feb 1, 2018
9065e08
lib: provide proper deprecation code
BridgeAR Feb 10, 2018
6696271
async_hooks: remove runtime deprecation
ofrobots Jun 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
async_hooks: remove runtime deprecation 
As part of the backport to 8.x, this change removes the runtime
deprecation making this a docs-only deprecation for 8.x.

PR-URL: #19517
Reviewed-By: mcollina - Matteo Collina <matteo.collina@gmail.com>
  • Loading branch information
@ofrobots
ofrobots committed Jun 28, 2018
commit 6696271837cddc488e70ffc0fd073fd7a644240d
13 changes: 0 additions & 13 deletions lib/async_hooks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,17 +143,6 @@ function triggerAsyncId() {

const destroyedSymbol = Symbol('destroyed');

let emitBeforeAfterWarning = true;
function showEmitBeforeAfterWarning() {
if (emitBeforeAfterWarning) {
process.emitWarning(
'asyncResource.emitBefore and emitAfter are deprecated. Please use ' +
'asyncResource.runInAsyncScope instead',
'DeprecationWarning', 'DEP0098');
emitBeforeAfterWarning = false;
}
}

class AsyncResource {
constructor(type, opts = {}) {
if (typeof type !== 'string')
Expand Down Expand Up @@ -189,13 +178,11 @@ class AsyncResource {
}

emitBefore() {
showEmitBeforeAfterWarning();
emitBefore(this[async_id_symbol], this[trigger_async_id_symbol]);
return this;
}

emitAfter() {
showEmitBeforeAfterWarning();
emitAfter(this[async_id_symbol]);
return this;
}
Expand Down