Skip to content

test: rename regression tests with descriptive file names #19212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ryzokuken wants to merge 10 commits into from
Closed

test: rename regression tests with descriptive file names #19212

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ae40a78
test: rename test-regress-GH-1531
ryzokuken Mar 7, 2018
363aa96
test: rename test-regress-GH-2245
ryzokuken Mar 7, 2018
9de9014
test: rename test-regress-GH-3238
ryzokuken Mar 7, 2018
18c7841
test: rename test-regress-GH-3542
ryzokuken Mar 8, 2018
8bdf66f
test: rename test-regress-GH-3739
ryzokuken Mar 8, 2018
3dd9688
test: change test-fs-existssync-false.js
ryzokuken Mar 8, 2018
edd6a58
test: rename test-regress-GH-4256
ryzokuken Mar 8, 2018
8e50585
test: handle (almost) all nits in #19212
ryzokuken Mar 8, 2018
fb4050f
test: handle all nits in #19212
ryzokuken Mar 8, 2018
c8654f5
test: punctuate tests in #19212
ryzokuken Mar 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: punctuate tests in #19212 
Refs: #19212
  • Loading branch information
@ryzokuken
ryzokuken committed Mar 8, 2018
commit c8654f5780523e7e34f8d888b90a557c0a2e4bdc
2 changes: 1 addition & 1 deletion test/parallel/test-fs-existssync-false.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
const common = require('../common');
const tmpdir = require('../common/tmpdir');

// This test ensures that fs.existsSync doesn't incorrectly return false
// This test ensures that fs.existsSync doesn't incorrectly return false.
// (especially on Windows)
Copy link
Copy Markdown
Member

@BridgeAR BridgeAR Mar 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: It would be nice to punctuate the new comments.

// https://github.com/nodejs/node-v0.x-archive/issues/3739

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-fs-readfilesync-enoent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ if (!common.isWindows)
common.skip('Windows specific test.');

// This test ensures fs.realpathSync works on properly on Windows without
// throwing ENOENT when the path involves a fileserver
// throwing ENOENT when the path involves a fileserver.
// https://github.com/nodejs/node-v0.x-archive/issues/3542

const assert = require('assert');
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-http-request-agent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ if (!common.hasCrypto)

const fixtures = require('../common/fixtures');

// This test ensures that a http request callback is called
// when the agent option is set
// This test ensures that a http request callback is called when the agent
// option is set.
// See https://github.com/nodejs/node-v0.x-archive/issues/1531

const https = require('https');
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-process-domain-segfault.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
require('../common');

// This test ensures that setting `process.domain` to `null` does not result in
// node crashing with a segfault
// node crashing with a segfault.
// https://github.com/nodejs/node-v0.x-archive/issues/4256

process.domain = null;
Expand Down