Skip to content

[v9.x] backport 18656 + 19002 #19185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 6 commits into from
Closed

[v9.x] backport 18656 + 19002 #19185

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8ff43ad
src: handle exceptions in env->SetImmediates
jasnell Jan 26, 2018
9f426f7
src: prevent persistent handle resource leaks
bnoordhuis Feb 21, 2018
097009a
[squash] v9.x-specific fixups
addaleax Mar 6, 2018
3de8e57
src: remove unnecessary Reset() calls
bnoordhuis Feb 21, 2018
8c363cd
src: don't touch js object in Http2Session dtor
bnoordhuis Feb 21, 2018
8827b71
http2: no stream destroy while its data is on the wire
addaleax Feb 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
src: don't touch js object in Http2Session dtor 
Don't try to update the internal field pointer of the JS object in the
destructor.

The garbage collector invokes the destructor when the object is
collected and is not necessarily in a valid state anymore.

PR-URL: #18656
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
  • Loading branch information
@bnoordhuis @addaleax
bnoordhuis authored and addaleax committed Mar 6, 2018
commit 8c363cd48f7334ec10155b1c00b13e504c61881e
2 changes: 0 additions & 2 deletions src/node_http2.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,8 +531,6 @@ Http2Session::Http2Session(Environment* env,

Http2Session::~Http2Session() {
CHECK_EQ(flags_ & SESSION_STATE_HAS_SCOPE, 0);
if (!object().IsEmpty())
ClearWrap(object());
DEBUG_HTTP2SESSION(this, "freeing nghttp2 session");
nghttp2_session_del(session_);
}
Expand Down