Skip to content

[v9.x backport] doc: fix/add link to Android info #19183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vsemozhetbyt wants to merge 24 commits into from
Closed

[v9.x backport] doc: fix/add link to Android info #19183

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
819ff1a
deps: cherry-pick 46c4979e86 from upstream v8
bnoordhuis Feb 21, 2018
62dc43d
src: clean up process.dlopen()
bnoordhuis Feb 22, 2018
86fa308
src: make process.dlopen() load well-known symbol
bnoordhuis Feb 22, 2018
6bd8c10
build: fix gocvr version used for coverage
mhdawson Mar 2, 2018
a3b9542
module: fix cyclical dynamic import
bmeck Feb 23, 2018
57ddfd1
doc: add simple example to rename function
punteek Feb 16, 2018
6ad9be0
doc: new team for bundlers or delivery of Node.js
mhdawson Mar 2, 2018
dc25929
deps: cherry-pick 0bcb1d6f from upstream V8
jakobkummerow Dec 5, 2017
d268061
doc: add introduced_in metadata to _toc.md
Trott Mar 4, 2018
15281b0
doc: update cc list
BridgeAR Mar 2, 2018
83c912a
doc: remove tentativeness in pull-requests.md
Trott Mar 4, 2018
7861df9
doc: remove subsystem from pull request template
Trott Mar 4, 2018
d6153e9
src: refactor GetPeerCertificate
danbev Mar 2, 2018
0b22bab
src: use std::unique_ptr for STACK_OF(X509)
bnoordhuis Mar 2, 2018
7448712
test: move require http2 to after crypto check
danbev Mar 3, 2018
4829469
src: #include <stdio.h>" to iculslocs
srl295 Mar 5, 2018
c89e8f3
perf_hooks: fix timing
TimothyGu Feb 25, 2018
c81a391
test: add more information to assert.strictEqual
ryzokuken Mar 6, 2018
03784d7
src: handle exceptions in env->SetImmediates
jasnell Jan 26, 2018
6e1bed1
src: prevent persistent handle resource leaks
bnoordhuis Feb 21, 2018
5b4eeb8
src: remove unnecessary Reset() calls
bnoordhuis Feb 21, 2018
d3eaf77
src: don't touch js object in Http2Session dtor
bnoordhuis Feb 21, 2018
4e9ac10
http2: no stream destroy while its data is on the wire
addaleax Feb 26, 2018
462dff2
doc: fix/add link to Android info
vsemozhetbyt Feb 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
build: fix gocvr version used for coverage 
Fix the gcovr version to a fixed version and uses patches
specific to that version. This avoids us being broken by
changes in the gcovr repo. Using file name for patches
specific to the version level will allow us to move up when
necessary without breaking coverage for earlier versions
of Node.js

PR-URL: #19094
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
  • Loading branch information
@mhdawson @MylesBorins
mhdawson authored and MylesBorins committed Mar 6, 2018
commit 6bd8c10d77b786815f8c2bd2d9a6eb381a69a924
10 changes: 5 additions & 5 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,13 +172,13 @@ coverage-build: all
$(NODE) ./deps/npm install istanbul-merge --no-save --no-package-lock; fi
if [ ! -d node_modules/nyc ]; then \
$(NODE) ./deps/npm install nyc --no-save --no-package-lock; fi
if [ ! -d gcovr ]; then git clone --depth=1 \
if [ ! -d gcovr ]; then git clone -b 3.4 --depth=1 \
--single-branch git://github.com/gcovr/gcovr.git; fi
if [ ! -d build ]; then git clone --depth=1 \
--single-branch https://github.com/nodejs/build.git; fi
if [ ! -f gcovr/gcovr/gcov.py.orig ]; then \
(cd gcovr && patch -b -N -p1 < \
"$(CURDIR)/build/jenkins/scripts/coverage/gcovr-patches.diff"); fi
if [ ! -f gcovr/scripts/gcovr.orig ]; then \
(cd gcovr && patch -N -p1 < \
"$(CURDIR)/build/jenkins/scripts/coverage/gcovr-patches-3.4.diff"); fi
if [ -d lib_ ]; then $(RM) -r lib; mv lib_ lib; fi
mv lib lib_
$(NODE) ./node_modules/.bin/nyc instrument --extension .js --extension .mjs lib_/ lib/
Expand All @@ -203,7 +203,7 @@ coverage-test: coverage-build
(cd lib && .$(NODE) ../node_modules/.bin/nyc report \
--temp-directory "$(CURDIR)/.cov_tmp" \
--report-dir "../coverage")
-(cd out && PYTHONPATH=$(CURDIR)/gcovr $(PYTHON) -m gcovr --gcov-exclude='.*deps' \
-(cd out && "../gcovr/scripts/gcovr" --gcov-exclude='.*deps' \
--gcov-exclude='.*usr' -v -r Release/obj.target \
--html --html-detail -o ../coverage/cxxcoverage.html \
--gcov-executable="$(GCOV)")
Expand Down