Skip to content

[v9.x backport] util: use blue on non-windows systems for number #19180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
devsnek wants to merge 25 commits into from
Closed

[v9.x backport] util: use blue on non-windows systems for number #19180

Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
8a8c792
test: http2 client setNextStreamID errors
trivikr Feb 18, 2018
818c2fb
deps: cherry-pick 46c4979e86 from upstream v8
bnoordhuis Feb 21, 2018
bb51e95
src: clean up process.dlopen()
bnoordhuis Feb 22, 2018
1d1a241
src: make process.dlopen() load well-known symbol
bnoordhuis Feb 22, 2018
a243961
build: fix gocvr version used for coverage
mhdawson Mar 2, 2018
bc1038a
module: fix cyclical dynamic import
bmeck Feb 23, 2018
f79d726
doc: add simple example to rename function
punteek Feb 16, 2018
d03929d
doc: new team for bundlers or delivery of Node.js
mhdawson Mar 2, 2018
0ebc7b9
deps: cherry-pick 0bcb1d6f from upstream V8
jakobkummerow Dec 5, 2017
f691777
doc: add introduced_in metadata to _toc.md
Trott Mar 4, 2018
241d1b0
doc: update cc list
BridgeAR Mar 2, 2018
ae2009d
doc: remove tentativeness in pull-requests.md
Trott Mar 4, 2018
4387a2c
doc: remove subsystem from pull request template
Trott Mar 4, 2018
c1b3a15
src: refactor GetPeerCertificate
danbev Mar 2, 2018
8116019
src: use std::unique_ptr for STACK_OF(X509)
bnoordhuis Mar 2, 2018
7fa236b
test: move require http2 to after crypto check
danbev Mar 3, 2018
823f85f
src: #include <stdio.h>" to iculslocs
srl295 Mar 5, 2018
bbeb2a5
perf_hooks: fix timing
TimothyGu Feb 25, 2018
7b4c9a4
test: add more information to assert.strictEqual
ryzokuken Mar 6, 2018
7acf21a
src: handle exceptions in env->SetImmediates
jasnell Jan 26, 2018
d8fef17
src: prevent persistent handle resource leaks
bnoordhuis Feb 21, 2018
52e1830
src: remove unnecessary Reset() calls
bnoordhuis Feb 21, 2018
c5f3d78
src: don't touch js object in Http2Session dtor
bnoordhuis Feb 21, 2018
759b210
http2: no stream destroy while its data is on the wire
addaleax Feb 26, 2018
0d28e9c
util: use blue on non-windows systems for number
devsnek Feb 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc: remove tentativeness in pull-requests.md 
There are some uses of "in general" that are unnecessary. (We don't need
to be tentative about the fact that tests should pass, for example.)

PR-URL: #19123
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
@Trott @MylesBorins
Trott authored and MylesBorins committed Mar 6, 2018
commit ae2009dd66fa2ed7540ce0f0cc5e37376b9a9816
12 changes: 6 additions & 6 deletions doc/guides/contributing/pull-requests.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,10 +401,10 @@ seem unfamiliar, refer to this
All Pull Requests require "sign off" in order to land. Whenever a contributor
reviews a Pull Request they may find specific details that they would like to
see changed or fixed. These may be as simple as fixing a typo, or may involve
substantive changes to the code you have written. In general, such requests
are intended to be helpful, but at times may come across as abrupt or unhelpful,
especially requests to change things that do not include concrete suggestions
on *how* to change them.
substantive changes to the code you have written. While such requests are
intended to be helpful, they may come across as abrupt or unhelpful, especially
requests to change things that do not include concrete suggestions on *how* to
change them.

Try not to be discouraged. If you feel that a particular review is unfair,
say so, or contact one of the other contributors in the project and seek their
Expand Down Expand Up @@ -610,8 +610,8 @@ however, will stay intact on the Pull Request page.
For the size of "one logical change",
[0b5191f](https://github.com/nodejs/node/commit/0b5191f15d0f311c804d542b67e2e922d98834f8)
can be a good example. It touches the implementation, the documentation,
and the tests, but is still one logical change. In general, the tests should
always pass when each individual commit lands on the master branch.
and the tests, but is still one logical change. All tests should always pass
when each individual commit lands on the master branch.

### Getting Approvals for Your Pull Request

Expand Down