Skip to content

[v8.x backport] node internals' postmortem metadata (#14901, #18530, #18653) #19176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mmarchini wants to merge 3 commits into from
Closed

[v8.x backport] node internals' postmortem metadata (#14901, #18530, #18653) #19176

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
77eb8e2
src, test: node internals' postmortem metadata
Dec 26, 2017
cd00e23
test: fix cctest -Wunused-variable warning
bnoordhuis Feb 2, 2018
0fce524
src: do not redefine private for GenDebugSymbols
joyeecheung Feb 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: fix cctest -Wunused-variable warning 
PR-URL: #18530
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
  • Loading branch information
@bnoordhuis
bnoordhuis authored and Matheus Marchini committed Mar 6, 2018
commit cd00e230a8f59d8b80f4779e315493651d40f188
2 changes: 1 addition & 1 deletion test/cctest/test_node_postmortem_metadata.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ TEST_F(DebugSymbolsTest, ReqWrapList) {
// NOTE (mmarchini): Workaround to fix failing tests on ARM64 machines with
// older GCC. Should be removed once we upgrade the GCC version used on our
// ARM64 CI machinies.
for (auto it : *(*env)->req_wrap_queue()) {}
for (auto it : *(*env)->req_wrap_queue()) (void) &it;

auto queue = reinterpret_cast<uintptr_t>((*env)->req_wrap_queue());
auto head = queue +
Expand Down