Skip to content

src: use smart pointer in AsyncWrap::WeakCallback #19168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danbev wants to merge 2 commits into from
Closed

src: use smart pointer in AsyncWrap::WeakCallback #19168

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7c25ee
src: use smart pointer in AsyncWrap::WeakCallback
danbev Mar 6, 2018
36f0e37
squash: add comment about scope of unique_ptr
danbev Mar 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
squash: add comment about scope of unique_ptr
  • Loading branch information
@danbev
danbev committed Mar 6, 2018
commit 36f0e370d561dc7d7e15c3d130ccc84b140a5fdb
1 change: 1 addition & 0 deletions src/async_wrap.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,6 +422,7 @@ void AsyncWrap::WeakCallback(const v8::WeakCallbackInfo<DestroyParam>& info) {
if (val->IsFalse()) {
AsyncWrap::EmitDestroy(env, p->asyncId);
}
// unique_ptr goes out of scope here and pointer is deleted.
}


Expand Down