Skip to content

test: rename regression tests with descriptive file names #19161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ryzokuken wants to merge 8 commits into from
Closed

test: rename regression tests with descriptive file names #19161

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
51e7956
test: rename test-regress-GH-1726
ryzokuken Mar 6, 2018
713a7d5
test: rename test-regress-GH-1697
ryzokuken Mar 6, 2018
e699b92
test: rename test-regress-GH-4015
ryzokuken Mar 6, 2018
7b91ada
test: rename test-regress-GH-4027
ryzokuken Mar 6, 2018
24016c4
test: rename tests to remove "regress" keyword
ryzokuken Mar 6, 2018
5b96920
test: address nits and rename the corresponding fixture
ryzokuken Mar 6, 2018
8532aaa
test: rename test-regress-GH-784.js
ryzokuken Mar 6, 2018
c3cc56b
test: rename test-regress-GH-877.js
ryzokuken Mar 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: rename test-regress-GH-784.js 
Rename the test appropriately alongside mentioning the subsystem
Also, make a few basic changes to make sure the test conforms
to the standard test structure

Refs: #19105
Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure
  • Loading branch information
@ryzokuken
ryzokuken committed Mar 6, 2018
commit 8532aaa258935b9d47073daca2e39a6dcfe6ae8a
10 changes: 5 additions & 5 deletions test/sequential/test-regress-GH-784.js → test/sequential/test-http-econnrefused.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,15 @@
// USE OR OTHER DEALINGS IN THE SOFTWARE.

'use strict';
// Regression test for GH-784
// https://github.com/joyent/node/issues/784
//
const common = require('../common');

// The test works by making a total of 8 requests to the server. The first
// two are made with the server off - they should come back as ECONNREFUSED.
// The next two are made with server on - they should come back successful.
// The next two are made with the server off - and so on. Without the fix
// we were experiencing parse errors and instead of ECONNREFUSED.
const common = require('../common');
// we were experiencing parse errors instead of ECONNREFUSED.
// https://github.com/nodejs/node-v0.x-archive/issues/784

const http = require('http');
const assert = require('assert');

Expand Down