Skip to content

process: unify error message from chdir() errors #19088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SirR4T wants to merge 2 commits into from
Closed

process: unify error message from chdir() errors #19088

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5cdc716
process: unify error message from chdir() errors
Mar 2, 2018
ba28e97
process: review comments for error message changes
Mar 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
process: unify error message from chdir() errors
  • Loading branch information
Sarat Addepalli committed Mar 2, 2018
commit 5cdc716d1493ec11e91548dcaf87721f180ca435
2 changes: 1 addition & 1 deletion src/node.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1578,7 +1578,7 @@ static void Chdir(const FunctionCallbackInfo<Value>& args) {
node::Utf8Value path(args.GetIsolate(), args[0]);
int err = uv_chdir(*path);
if (err) {
return env->ThrowUVException(err, "uv_chdir");
return env->ThrowUVException(err, "chdir", nullptr, *path, nullptr);
}
}

Expand Down
19 changes: 19 additions & 0 deletions test/parallel/test-fs-chdir-errormessage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
'use strict';

require('../common');
const process = require('process');
Copy link
Copy Markdown
Contributor

@cjihrig cjihrig Mar 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to require process

const assert = require('assert');

assert.throws(
Copy link
Copy Markdown
Member

@richardlau richardlau Mar 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use common.expectsError instead?

() => {
process.chdir('does-not-exist');
},
(error) => {
assert.strictEqual(error instanceof Error, true);
assert.strictEqual(
error.message,
"ENOENT: no such file or directory, chdir 'does-not-exist'"
);
return true;
}
);