Skip to content

src: add incr/decr operators for Reference #19083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danbev wants to merge 5 commits into from
Closed

src: add incr/decr operators for Reference #19083

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5cb22f6
src: add incr/decr operators for Reference
danbev Mar 2, 2018
4fca5f7
squash: fix return statements
danbev Mar 3, 2018
5c687c0
squash: call inc operator for decr operator
danbev Mar 5, 2018
651bfb2
squash: add test for overload operators
danbev Mar 5, 2018
18f46e8
squash: add test for Reference overloads
danbev Mar 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
squash: call inc operator for decr operator
  • Loading branch information
@danbev
danbev committed Mar 9, 2018
commit 5c687c07789fcc66faca8e41d27f665a66ad9e32
8 changes: 1 addition & 7 deletions src/aliased_buffer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,13 +154,7 @@ class AliasedBuffer {

template <typename T>
inline Reference& operator-=(const T& val) {
const T current = aliased_buffer_->GetValue(index_);
aliased_buffer_->SetValue(index_, current - val);
return *this;
}

inline Reference& operator-=(const Reference& val) {
return *this->operator-=(static_cast<NativeT>(val));
return this->operator+=(-val);
Copy link
Copy Markdown
Member

@TimothyGu TimothyGu Mar 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just making sure, this still works if val is a reference?

Copy link
Copy Markdown
Member

@TimothyGu TimothyGu Mar 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would definitely be good to test for that.

}

private:
Expand Down