Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
8e7ac25
http, tls: better support for IPv6 addresses
mattiasholmlund Aug 10, 2017
e021fb7
doc,test: mention Duplex support for TLS
addaleax Dec 11, 2017
4879038
tools: add number-isnan rule
maclover7 Dec 11, 2017
969c39e
lib: enable dot-notation eslint rule
apapirovski Jan 5, 2018
16ef24b
test: use smaller input file for test-zlib.js
Trott Jan 5, 2018
17c88c4
doc: examples for fast-tracking regression fixes
refack Nov 26, 2017
37071b8
path: fix path.normalize for relative paths
starkwang Jan 4, 2018
838f7bd
doc: be less tentative about undefined behavior
Trott Jan 10, 2018
1505b71
doc: add Leko to collaborators
Leko Jan 11, 2018
8f9362d
doc: add documentation for deprecation properties
maclover7 Oct 26, 2017
2004efd
test: improve to use template string
sreepurnajasti Jan 10, 2018
eaa30e4
test: simplify loadDHParam in TLS test
tniessen Jan 11, 2018
df038ad
fs: fix options.end of fs.ReadStream()
Jan 12, 2018
2c21421
doc: simplify sentences that use "considered"
Trott Jan 11, 2018
2e76df5
doc: warn users about non-ASCII paths on build
Nov 4, 2017
b83b104
doc: add builtin module in building.md
Suixinlei Dec 16, 2017
46e4311
doc: V8 branch used in 8.x not active anymore
fhinkel Jan 15, 2018
1e8d120
doc: Add example of null to assert.ifError
Leko Jan 18, 2018
27107b9
test: use countdown timer
daxlab Nov 26, 2017
7fc5c69
doc: use PBKDF2 in text
tniessen Jan 21, 2018
bb2d292
test: change assert message to default
ryanmahan Jan 19, 2018
d333ba5
doc: add vdeturckheim as collaborator
vdeturckheim Jan 29, 2018
fdf73b1
test: preserve env in test cases
BethGriggs Aug 14, 2017
1246f72
2018-03-06, Version 6.13.1 'Boron' (LTS)
MylesBorins Feb 27, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc: simplify sentences that use "considered"
Change many instances of "x is considered to be y" to "x is y".

PR-URL: #18095
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
Trott authored and MylesBorins committed Feb 27, 2018
commit 2c21421092125da13020dd709c15ed533ccc43d7
8 changes: 4 additions & 4 deletions doc/api/child_process.md
Original file line number Diff line number Diff line change
Expand Up @@ -974,10 +974,10 @@ process.send({ foo: 'bar' });
Child Node.js processes will have a [`process.send()`][] method of their own that
allows the child to send messages back to the parent.

There is a special case when sending a `{cmd: 'NODE_foo'}` message. All messages
containing a `NODE_` prefix in its `cmd` property are considered to be reserved
for use within Node.js core and will not be emitted in the child's
[`process.on('message')`][] event. Rather, such messages are emitted using the
There is a special case when sending a `{cmd: 'NODE_foo'}` message. Messages
containing a `NODE_` prefix in the `cmd` property are reserved for use within
Node.js core and will not be emitted in the child's [`process.on('message')`][]
event. Rather, such messages are emitted using the
`process.on('internalMessage')` event and are consumed internally by Node.js.
Applications should avoid using such messages or listening for
`'internalMessage'` events as it is subject to change without notice.
Expand Down
2 changes: 1 addition & 1 deletion doc/api/http.md
Original file line number Diff line number Diff line change
Expand Up @@ -550,7 +550,7 @@ Once a socket is assigned to this request and is connected
added: v0.5.9
-->

* `timeout` {number} Milliseconds before a request is considered to be timed out.
* `timeout` {number} Milliseconds before a request times out.
* `callback` {Function} Optional function to be called when a timeout occurs. Same as binding to the `timeout` event.

Once a socket is assigned to this request and is connected
Expand Down
4 changes: 2 additions & 2 deletions doc/api/readline.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ The `'close'` event is emitted when one of the following occur:

The listener function is called without passing any arguments.

The `readline.Interface` instance should be considered to be "finished" once
the `'close'` event is emitted.
The `readline.Interface` instance is finished once the `'close'` event is
emitted.

### Event: 'line'
<!-- YAML
Expand Down
3 changes: 1 addition & 2 deletions doc/guides/maintaining-V8.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@ For example, at the time of this writing:
* **Beta**: V8 5.5 is currently in beta. It will be promoted to stable next; approximately 6 weeks after V8 5.4 shipped as stable.
* **Master**: V8 tip-of-tree corresponds to V8 5.6. This branch gets regularly released as part of the Chromium **canary** builds. This branch will be promoted to beta next when V8 5.5 ships as stable.

All older branches are considered **abandoned**, and are not maintained by the
V8 team.
All older branches are abandoned and are not maintained by the V8 team.

## V8 merge process overview

Expand Down