Skip to content

events: show throw stack trace for uncaught exception #19003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 6 commits into from
Closed

events: show throw stack trace for uncaught exception #19003

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c5b6a2d
events: show throw stack trace for uncaught exception
addaleax Feb 26, 2018
3017598
[squash] better comment text
addaleax Feb 26, 2018
3c3fa83
[squash] more tests
addaleax Feb 26, 2018
70457e0
[squash] remove at at
addaleax Feb 26, 2018
9cb8461
[squash] hide internals better
addaleax Feb 26, 2018
92b6be1
[squash] bridgear comments
addaleax Mar 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[squash] bridgear comments
  • Loading branch information
@addaleax
addaleax committed Mar 1, 2018
commit 92b6be15e78f8c6779ec95c500cb916c0f45b7d5
11 changes: 1 addition & 10 deletions lib/events.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,22 +124,13 @@ function longestSeqContainedIn(a, b) {
return [ 0, 0, 0 ];
}

function longestCommonSubsequence(a, b) {
const [ l1, i1, j1 ] = longestSeqContainedIn(a, b);
const [ l2, i2, j2 ] = longestSeqContainedIn(b, a);
if (l1 > l2)
return [ l1, j1, i1 ];
else
return [ l2, i2, j2 ];
}

function enhanceStackTrace(err, own) {
const sep = '\nEmitted \'error\' event at:\n';

const errStack = err.stack.split('\n').slice(1);
const ownStack = own.stack.split('\n').slice(1);

const [ len, off ] = longestCommonSubsequence(errStack, ownStack);
const [ len, off ] = longestSeqContainedIn(ownStack, errStack);
if (len > 0) {
ownStack.splice(off + 1, len - 1,
' [... lines matching original stack trace ...]');
Expand Down
16 changes: 16 additions & 0 deletions test/parallel/test-events-uncaught-exception-stack.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
'use strict';
const common = require('../common');
const assert = require('assert');
const EventEmitter = require('events');

// Tests that the error stack where the exception was thrown is *not* appended.

process.on('uncaughtException', common.mustCall((err) => {
const lines = err.stack.split('\n');
assert.strictEqual(lines[0], 'Error');
lines.slice(1).forEach((line) => {
assert(/^ at/.test(line), `${line} has an unexpected format`);
});
}));

new EventEmitter().emit('error', new Error());