Skip to content

src,http2: use native-layer pipe mechanism from FileHandle instead of synchronous I/O #18936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 11 commits into from
Closed

src,http2: use native-layer pipe mechanism from FileHandle instead of synchronous I/O #18936

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5e63bf5
src: tighten handle scopes for stream operations
addaleax Feb 24, 2018
68a6d15
src: make `FileHandle` a (readonly) `StreamBase`
addaleax Feb 12, 2018
80d9580
src: give StreamBases the capability to ask for data
addaleax Feb 22, 2018
21587ba
src: add helper for before/after scope without JS calls
addaleax Mar 7, 2018
0414d88
src: introduce native-layer stream piping
addaleax Feb 13, 2018
551db4d
[squash] fix debug build
addaleax Mar 14, 2018
a91ab8d
http2: use native pipe instead of synchronous I/O
addaleax Feb 13, 2018
3be8a42
http2: remove regular-file-only restriction
addaleax Feb 13, 2018
cf72772
src: use ObjectTemplate for creating stream req objs
addaleax Feb 23, 2018
4199388
benchmark: remove excessive value from http2 benchmark
addaleax Mar 7, 2018
d8eb113
http: align parser with StreamBase interface changes
addaleax Mar 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[squash] fix debug build
  • Loading branch information
@addaleax
addaleax committed Mar 14, 2018
commit 551db4dc5afa047812899117df69cdc2bf271f9a
1 change: 1 addition & 0 deletions src/stream_pipe.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ void StreamPipe::Unpipe() {

// Delay the JS-facing part with SetImmediate, because this might be from
// inside the garbage collector, so we can’t run JS here.
HandleScope handle_scope(env()->isolate());
env()->SetImmediate([](Environment* env, void* data) {
StreamPipe* pipe = static_cast<StreamPipe*>(data);

Expand Down