Skip to content

Fixed broken link in onboarding.md. Removed Members team link. #18878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
justin0022 wants to merge 5 commits into from
Closed

Fixed broken link in onboarding.md. Removed Members team link. #18878

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8c82526
Fixed broken link in onboarding.md. Removed Members team link.
justin0022 Feb 20, 2018
a302929
Reverted link back to nodejs/team/collaborators
justin0022 Feb 20, 2018
216f86a
Fixed typo
justin0022 Feb 20, 2018
de0085b
Removed comma, as requested
justin0022 Feb 20, 2018
9ba2953
Removed 'if they are not already part of it'
justin0022 Feb 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fixed broken link in onboarding.md. Removed Members team link.
  • Loading branch information
@justin0022
justin0022 committed Feb 21, 2018
commit 8c825268728128c070fbeea5c34fa2c01a74be86
5 changes: 2 additions & 3 deletions doc/onboarding.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,8 @@ onboarding session.

## Fifteen minutes before the onboarding session

* Prior to the onboarding session, add the new Collaborator to
[the Collaborators team](https://github.com/orgs/nodejs/teams/collaborators),
and to [the Members team](https://github.com/orgs/nodejs/teams/members) if
* Prior to the onboarding session, add the new Collaborator to the
Copy link
Copy Markdown
Member

@Trott Trott Feb 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's an extra the at the end of this line (or an extra one at the beginning of the next line).

[the Collaborators team](https://github.com/nodejs/node#collaborators), if
they are not already part of it. Note that this is the step that gives the
account elevated privileges, so do not perform this step (or any subsequent
steps) unless two-factor authentication is enabled on the new Collaborator's
Expand Down