Skip to content

lib: new error implementation #18857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 7 commits into from
Closed

lib: new error implementation #18857

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
690d6f5
errors: implement new error handling
BridgeAR Feb 19, 2018
cc0edb9
errors: update all internal errors
BridgeAR Feb 19, 2018
a51e50d
console: port errors to new system
BridgeAR Feb 19, 2018
ae87200
errors: add comments about falsy error types
BridgeAR Feb 19, 2018
474c498
errors: simplify sysError
BridgeAR Feb 19, 2018
5ee0ffb
fixup: nicer extra class implementation
BridgeAR Feb 19, 2018
e0df496
fixup: rename
BridgeAR Feb 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup: rename
  • Loading branch information
@BridgeAR
BridgeAR committed Feb 22, 2018
commit e0df49665c620eda86281239fbb1abf4251c00fe
6 changes: 3 additions & 3 deletions lib/internal/errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ function makeNodeError(Base) {
};
}

function makeNodeError2(Base, key) {
function makeNodeErrorWithCode(Base, key) {
return class NodeError extends Base {
constructor(...args) {
super(message(key, args));
Expand Down Expand Up @@ -126,10 +126,10 @@ function makeNodeError2(Base, key) {
function E(sym, val, def, ...otherClasses) {
messages.set(sym, val);
if (def === undefined) return;
def = makeNodeError2(def, sym);
def = makeNodeErrorWithCode(def, sym);
if (otherClasses.length !== 0) {
otherClasses.forEach((clazz) => {
def[clazz.name] = makeNodeError2(clazz, sym);
def[clazz.name] = makeNodeErrorWithCode(clazz, sym);
});
}
codes[sym] = def;
Expand Down