Skip to content

test: check symbols in shared lib #18806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yhwang wants to merge 1 commit into from
Closed

test: check symbols in shared lib #18806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: check symbols in shared lib 
When building the node with `--shared` option, we need
to verify the symbols in shared lib instead of executable.

Refs: #18535

Signed-off-by: Yihong Wang <yh.wang@ibm.com>
  • Loading branch information
@yhwang
yhwang committed Feb 20, 2018
commit 01374fea9ad49780fe7ab9eacf7fad769fa559c1
16 changes: 15 additions & 1 deletion test/common/shared-lib-util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/* eslint-disable node-core/required-modules */
'use strict';
const common = require('../common');
const path = require('path');

// If node executable is linked to shared lib, need to take care about the
Expand Down Expand Up @@ -27,3 +27,17 @@ exports.addLibraryPath = function(env) {
(env.PATH ? env.PATH + path.delimiter : '') +
path.dirname(process.execPath);
};

// Get the full path of shared lib
exports.getSharedLibPath = function() {
if (common.isWindows) {
return path.join(path.dirname(process.execPath), 'node.dll');
} else if (common.isOSX) {
return path.join(path.dirname(process.execPath),
`libnode.${process.config.variables.shlib_suffix}`);
} else {
return path.join(path.dirname(process.execPath),
'lib.target',
`libnode.${process.config.variables.shlib_suffix}`);
}
};
8 changes: 7 additions & 1 deletion test/parallel/test-postmortem-metadata.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,13 @@
const common = require('../common');
const assert = require('assert');
const { spawnSync } = require('child_process');
const args = [process.execPath];
const { getSharedLibPath } = require('../common/shared-lib-util.js');

// For shared lib case, check shared lib instead
const args = [
process.config.variables.node_shared ?
getSharedLibPath() : process.execPath
];

if (common.isAIX)
args.unshift('-Xany', '-B');
Expand Down