Skip to content

buffer: improve fill & normalizeEncoding performance #18790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 5 commits into from
Closed

buffer: improve fill & normalizeEncoding performance #18790

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
440da3d
buffer: improve Buffer#fill performance
BridgeAR Feb 14, 2018
0b416c2
benchmark: add buffer fill benchmark
BridgeAR Feb 14, 2018
acab8bd
benchmark: rename file
BridgeAR Feb 14, 2018
f8249bb
lib: improve normalize encoding performance
BridgeAR Feb 14, 2018
c5aa244
buffer: stricter isEncoding
BridgeAR Feb 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
benchmark: add buffer fill benchmark
  • Loading branch information
@BridgeAR
BridgeAR committed Feb 22, 2018
commit 0b416c220f262c953c9a6f7163afa522dab8b80c
31 changes: 31 additions & 0 deletions benchmark/buffers/buffer-fill.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
'use strict';
const common = require('../common.js');

const bench = common.createBenchmark(main, {
type: [
'fill(0)',
'fill("")',
'fill(100)',
'fill(400)',
'fill("t")',
'fill("test")',
'fill("t", "utf8")',
'fill("t", 0, "utf8")',
'fill("t", 0)',
'fill(Buffer.alloc(1), 0)'
],
size: [2 ** 8, 2 ** 13, 2 ** 16],
n: [2e4]
});

function main({ n, type, size }) {
const buffer = Buffer.allocUnsafe(size);
const testFunction = new Function('b', `
for (var i = 0; i < ${n}; i++) {
b.${type || 'fill(0)'};
}
`);
bench.start();
testFunction(buffer);
bench.end(n);
}