Skip to content

perf_hooks: emit user timing marks, measures and timerify to trace events #18789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasnell wants to merge 3 commits into from
Closed

perf_hooks: emit user timing marks, measures and timerify to trace events #18789

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
47a1898
perf_hooks: eliminate deprecation warning
jasnell Feb 14, 2018
a00b03a
perf_hooks: emit trace events for marks, measures, and timerify
jasnell Feb 14, 2018
02adcf7
perf_hooks: make PerformanceObserver an AsyncResource
jasnell Feb 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
perf_hooks: make PerformanceObserver an AsyncResource
  • Loading branch information
@jasnell
jasnell committed Feb 26, 2018
commit 02adcf7fd283ec3dd029a1dbfc91b330bdb246b6
6 changes: 4 additions & 2 deletions lib/perf_hooks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ const {
NODE_PERFORMANCE_MILESTONE_PRELOAD_MODULE_LOAD_END
} = constants;

const { AsyncResource } = require('async_hooks');
const L = require('internal/linkedlist');
const kInspect = require('internal/util').customInspectSymbol;
const { inherits } = require('util');
Expand Down Expand Up @@ -317,12 +318,13 @@ class PerformanceObserverEntryList {
}
}

class PerformanceObserver {
class PerformanceObserver extends AsyncResource {
constructor(callback) {
if (typeof callback !== 'function') {
const errors = lazyErrors();
throw new errors.TypeError('ERR_INVALID_CALLBACK');
}
super('PerformanceObserver');
Object.defineProperties(this, {
[kTypes]: {
enumerable: false,
Expand Down Expand Up @@ -568,7 +570,7 @@ function getObserversList(type) {

function doNotify() {
this[kQueued] = false;
this[kCallback](this[kBuffer], this);
this.runInAsyncScope(this[kCallback], this, this[kBuffer], this);
this[kBuffer][kEntries] = [];
L.init(this[kBuffer][kEntries]);
}
Expand Down