Skip to content

tools: enable no-unsafe-finally #18745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 2 commits into from
Closed

tools: enable no-unsafe-finally #18745

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
667bd04
tools: enable no-unsafe-finally
BridgeAR Feb 13, 2018
485b3cb
fixup: address comment
BridgeAR Feb 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
tools: enable no-unsafe-finally 
This enables the `no-unsafe-finally` eslint rule to make sure we
have a proper control flow in try / catch.
  • Loading branch information
@BridgeAR
BridgeAR committed Feb 13, 2018
commit 667bd049f237c34df1b343a84d43bb0dc6146fbb
1 change: 1 addition & 0 deletions .eslintrc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,7 @@ rules:
}]
no-tabs: error
no-trailing-spaces: error
no-unsafe-finally: error
object-curly-spacing: [error, always]
one-var-declaration-per-line: error
operator-linebreak: [error, after]
Expand Down
12 changes: 4 additions & 8 deletions test/common/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,17 +504,13 @@ exports.canCreateSymLink = function() {
const whoamiPath = path.join(process.env['SystemRoot'],
'System32', 'whoami.exe');

let err = false;
let output = '';

try {
output = execSync(`${whoamiPath} /priv`, { timout: 1000 });
} catch (e) {
err = true;
} finally {
if (err || !output.includes('SeCreateSymbolicLinkPrivilege')) {
const output = execSync(`${whoamiPath} /priv`, { timout: 1000 });
if (!output.includes('SeCreateSymbolicLinkPrivilege')) {
return false;
}
Copy link
Copy Markdown
Member

@bnoordhuis bnoordhuis Feb 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be simplified to just this, I think?

return output.includes('SeCreateSymbolicLinkPrivilege');

And then you don't need the return true a few lines below.

Copy link
Copy Markdown
Member Author

@BridgeAR BridgeAR Feb 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yepp, absolutely

} catch (e) {
return false;
}
}

Expand Down