Skip to content

doc: add history for url.parse #18685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
styfle wants to merge 3 commits into from
Closed

doc: add history for url.parse #18685

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
158194e
doc: add history for url.parse
styfle Feb 9, 2018
c920a6d
doc: change wording on change description
styfle Feb 9, 2018
baeff0b
doc: add backticks around `null`
styfle Feb 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions doc/api/url.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1007,6 +1007,11 @@ The formatting process operates as follows:
### url.parse(urlString[, parseQueryString[, slashesDenoteHost]])
<!-- YAML
added: v0.1.25
changes:
- version: v9.0.0
pr-url: https://github.com/nodejs/node/pull/13606
description: The returned URL object `search` property is now null when
Copy link
Copy Markdown
Member

@TimothyGu TimothyGu Feb 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: object’s

Copy link
Copy Markdown
Member Author

@styfle styfle Feb 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I looked below and made this consistent with the parseQueryString.

If false, the query property on the returned URL object will be an unparsed, undecoded string. Defaults to false.

no query string is present.
-->

* `urlString` {string} The URL string to parse.
Expand Down