Skip to content

stream: always defer readable in EOF when sync #18615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mcollina wants to merge 2 commits into from
Closed

stream: always defer readable in EOF when sync #18615

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7465b32
stream: always defer readable in EOF when sync
mcollina Feb 7, 2018
d627429
nit
mcollina Feb 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
nit
  • Loading branch information
@mcollina
mcollina committed Feb 7, 2018
commit d62742980da71acbfa24b4036cf6f384f85defe0
4 changes: 2 additions & 2 deletions lib/_stream_readable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,8 +489,8 @@ function onEofChunk(stream, state) {
state.ended = true;

if (state.sync) {
// if we are sync and have data in the buffer, wait until next tick
// to emit the data. otherwise we risk emitting data in the flow()
// if we are sync, wait until next tick to emit the data.
// Otherwise we risk emitting data in the flow()
// the readable code triggers during a read() call
emitReadable(stream);
} else {
Expand Down