Skip to content

url: reduce deplicated codes in autoEscapeStr #18613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
starkwang wants to merge 5 commits into from
Closed

url: reduce deplicated codes in autoEscapeStr #18613

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e1eb30a
url: reduce deplicated codes in `autoEscapeStr`
starkwang Feb 7, 2018
ba9427c
[squash]fix performance regression
starkwang Feb 7, 2018
943d3a9
add benchmark
starkwang Feb 7, 2018
9db55c5
use array
starkwang Feb 7, 2018
2b82afc
use dense array
starkwang Feb 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add benchmark
  • Loading branch information
@starkwang
starkwang committed Feb 7, 2018
commit 943d3a91906fbcff1a5505d113f05206e5332482
22 changes: 22 additions & 0 deletions benchmark/url/url-parse.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
'use strict';
const common = require('../common.js');
const url = require('url');

const inputs = {
normal: 'http://foo.com/bar',
escaped: 'https://foo.bar/{}^`/abcd'
};

const bench = common.createBenchmark(main, {
type: Object.keys(inputs),
n: [1e7]
});

function main({ type, n }) {
const input = inputs[type] || '';

bench.start();
for (var i = 0; i < n; i += 1)
url.parse(input);
bench.end(n);
}