Skip to content

Revert "stream: defer readable and flow when sync" #18612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 2 commits into from
Closed

Revert "stream: defer readable and flow when sync" #18612

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
203e607
Revert "stream: defer readable and flow when sync"
addaleax Feb 7, 2018
1779c7d
test: keep test/parallel/test-stream-pipe-flow
mafintosh Feb 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: keep test/parallel/test-stream-pipe-flow 
Refs: #18515
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
@mafintosh @addaleax
mafintosh authored and addaleax committed Feb 7, 2018
commit 1779c7d68d167ee5eaecca48059d7852d06c9ff0
67 changes: 67 additions & 0 deletions test/parallel/test-stream-pipe-flow.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
'use strict';
const common = require('../common');
const { Readable, Writable, PassThrough } = require('stream');

{
let ticks = 17;

const rs = new Readable({
objectMode: true,
read: () => {
if (ticks-- > 0)
return process.nextTick(() => rs.push({}));
rs.push({});
rs.push(null);
}
});

const ws = new Writable({
highWaterMark: 0,
objectMode: true,
write: (data, end, cb) => setImmediate(cb)
});

rs.on('end', common.mustCall());
ws.on('finish', common.mustCall());
rs.pipe(ws);
}

{
let missing = 8;

const rs = new Readable({
objectMode: true,
read: () => {
if (missing--) rs.push({});
else rs.push(null);
}
});

const pt = rs
.pipe(new PassThrough({ objectMode: true, highWaterMark: 2 }))
.pipe(new PassThrough({ objectMode: true, highWaterMark: 2 }));

pt.on('end', function() {
wrapper.push(null);
});

const wrapper = new Readable({
objectMode: true,
read: () => {
process.nextTick(function() {
let data = pt.read();
if (data === null) {
pt.once('readable', function() {
data = pt.read();
if (data !== null) wrapper.push(data);
});
} else {
wrapper.push(data);
}
});
}
});

wrapper.resume();
wrapper.on('end', common.mustCall());
}