Skip to content

net: remove Socket.prototoype.read #18568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 1 commit into from
Closed

net: remove Socket.prototoype.read #18568

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
net: remove Socket.prototoype.read 
Unused since 34b535f.
  • Loading branch information
@addaleax
addaleax committed Feb 4, 2018
commit d52253a7b6664a00bb6763e6d4dd8d0f42a64fcf
9 changes: 0 additions & 9 deletions lib/net.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,15 +397,6 @@ function writeAfterFIN(chunk, encoding, cb) {
}
}

Socket.prototype.read = function(n) {
if (n === 0)
return stream.Readable.prototype.read.call(this, n);

this.read = stream.Readable.prototype.read;
this._consuming = true;
return this.read(n);
};

Socket.prototype.setTimeout = function(msecs, callback) {
// Type checking identical to timers.enroll()
msecs = validateTimerDuration(msecs);
Expand Down