Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
163 commits
Select commit Hold shift + click to select a range
39970e9
doc: un-mark Socket#write “removal” as notable change
addaleax Jan 10, 2018
506d85b
deps: cherry-pick c3458a8 from upstream V8
targos Jan 11, 2018
2a4f849
async_hooks: rename initTriggerId
AndreasMadsen Nov 22, 2017
f56eb2a
async_hooks: separate missing from default context
AndreasMadsen Nov 22, 2017
a880e27
async_hooks: use scope for defaultTriggerAsyncId
AndreasMadsen Nov 22, 2017
167e9c6
test: refactor test-repl
addaleax Dec 31, 2017
2eb1aa8
test: move common.fires() to inspector-helper
Trott Nov 29, 2017
df8cb40
errors: remove ERR_OUTOFMEMORY
tniessen Dec 27, 2017
733df36
test: update references to archived repository
tniessen Dec 31, 2017
56a9ae7
readline: update references to archived repository
tniessen Dec 31, 2017
722fe46
Revert "doc: import() is supported now"
MylesBorins Jan 14, 2018
dd56bd1
async_hooks: use typed array stack as fast path
addaleax Dec 19, 2017
8f8e747
lib: remove queue implementation from JSStreamWrap
addaleax Dec 29, 2017
dd72f9c
build: fix cctest target with --enable-static
liqyan Jan 4, 2018
278450f
doc: multiple updates to child_process.md
Trott Jan 5, 2018
3456e61
test: use smaller input file for test-zlib.js
Trott Jan 5, 2018
f0a0fdd
doc: multiple updates to BUILDING.md
Trott Jan 4, 2018
a4ba791
benchmark: add JSStreamWrap benchmark
addaleax Jan 4, 2018
f693e81
n-api: throw RangeError in napi_create_dataview() with invalid range
romandev Dec 26, 2017
7911b9b
doc: examples for fast-tracking regression fixes
refack Nov 26, 2017
5ebd017
doc: add descriptions of state properties
jasnell Jan 8, 2018
470832f
path: fix path.normalize for relative paths
starkwang Jan 4, 2018
969c89b
build: fix Makefile wrt finding node executable
hashseed Jan 8, 2018
4bc4d00
tools: move eslint from tools to tools/node_modules
targos Dec 22, 2017
d349fca
tools: update ESLint to 4.15.0
targos Jan 9, 2018
715e673
tools: add babel-eslint
targos Dec 22, 2017
be9958a
tools: use babel-eslint as ESLint parser
targos Dec 22, 2017
5fccb6e
test: fix spelling in test case comments
tniessen Jan 6, 2018
dcdb646
lib: fix spelling in comments
tniessen Jan 6, 2018
96b0722
tls: refactor write queues away
addaleax Dec 27, 2017
de70a36
doc: be less tentative about undefined behavior
Trott Jan 10, 2018
7706e5f
test: remove orphaned entries from status
kfarnung Jan 10, 2018
1c81a05
doc: update pushStream docs to use err first
jasnell Jan 10, 2018
30e2221
doc: fix s/rstStream/close in example
jasnell Jan 11, 2018
645be73
perf_hooks,http2: add performance.clear()
jasnell Jan 8, 2018
eee40c7
http2: remember sent headers
jasnell Jan 8, 2018
d8ac817
build,win: restore vcbuild TAG functionality
rvagg Jan 8, 2018
0668a75
n-api: expose n-api version in process.versions
mhdawson Jan 9, 2018
afc30a5
doc: decapitalize primitive types
vsemozhetbyt Jan 11, 2018
bbdc3c4
doc: add Leko to collaborators
Leko Jan 11, 2018
0e8596e
doc: prefer make test-only when verifying the build
joyeecheung Jan 9, 2018
f8f809b
doc: add documentation for deprecation properties
maclover7 Oct 26, 2017
2aeb025
test: add common.crashOnUnhandledRejection to addons/callback-scope
Jan 13, 2018
ac0a0a6
src: harden JSStream callbacks
addaleax Jan 7, 2018
15aaf18
src: remove declarations for missing functions
addaleax Jan 13, 2018
87e3d3d
src: fix code coverage cleanup
mhdawson Jan 10, 2018
990abbf
doc: napi: fix unbalanced emphasis
ofrobots Jan 12, 2018
5a95905
doc: napi: make header style consistent
ofrobots Jan 12, 2018
1506eb5
build: remove bench-* targets
joyeecheung Jan 14, 2018
b05f09a
doc: suggest not to throw JS errors from C++
joyeecheung Jan 14, 2018
9edf023
n-api: throw RangeError napi_create_typedarray()
romandev Jan 8, 2018
217ddd8
src,doc,test: Fix common misspellings
silverwind Jan 14, 2018
0c8b5d5
test: fixed typos in napi test
furstenheim Jan 14, 2018
b4e7260
doc: fix typo in http2stream.close param default
maritz Jan 15, 2018
1dcae57
test: improve to use template string
sreepurnajasti Jan 10, 2018
2c4e021
build,win: update lint-cpp on Windows
kfarnung Jan 6, 2018
f81c622
build: refine static and shared lib build
yhwang Dec 5, 2017
6b687cf
cluster: resolve relative unix socket paths
Jan 8, 2018
63be0d6
test: simplify loadDHParam in TLS test
tniessen Jan 11, 2018
78e05da
test: use shorthand properties
tniessen Jan 11, 2018
3299a1a
test: remove trivial buffer imports
sreepurnajasti Jan 8, 2018
2fb5f19
doc: fix typo in TextEncoding section
yosuke-furukawa Jan 17, 2018
1d74c33
doc: update sample output for process.versions
mhdawson Jan 15, 2018
778d57c
fs: fix options.end of fs.ReadStream()
Jan 12, 2018
a1096a6
doc: simplify sentences that use "considered"
Trott Jan 11, 2018
1ef8f4e
doc: warn users about non-ASCII paths on build
Nov 4, 2017
926467a
doc: add builtin module in building.md
Suixinlei Dec 16, 2017
4b918d7
doc: remove uannecessary Require
mhdawson Jan 16, 2018
b553daa
doc: add change info for async_hooks.executionAsyncId()
Dec 21, 2017
361fd33
doc: V8 branch used in 8.x not active anymore
fhinkel Jan 15, 2018
077bcbd
src: introduce internal buffer slice constructor
addaleax Jan 8, 2018
b3332cc
http2: refactor read mechanism
addaleax Jan 8, 2018
5b5f5b1
test: add assertions for TextEncoder/Decoder
Jan 13, 2018
4513cbb
src: refactor callback #defines into C++ templates
addaleax Jan 13, 2018
8e084d8
http: simplify parser lifetime tracking
addaleax Jan 13, 2018
aa21d55
benchmark: remove redundant +
sreepurnajasti Dec 21, 2017
506c6e8
test: refactor test-http-parser
maclover7 Jan 18, 2018
485d656
lib: use american spelling as per style guide
sreepurnajasti Jan 18, 2018
70d6fda
build: remove unused vars from configure
bnoordhuis Jan 17, 2018
1c8df28
src: fix -Wimplicit-fallthrough warning
bnoordhuis Jan 17, 2018
ee6217a
http2: add checks for server close callback
jasnell Jan 16, 2018
61df843
doc: cjs format is now commonjs
devsnek Jan 15, 2018
5c5aa49
doc: improve process.platform
marswong Jan 9, 2018
761f26e
test: make async-wrap-getasyncid parallelizable
joyeecheung Jan 19, 2018
1556228
http: fix parsing of binary upgrade response body
bnoordhuis Dec 21, 2017
01599e2
doc: Add example of null to assert.ifError
Leko Jan 18, 2018
0250e1b
http: free the parser before emitting 'upgrade'
lpinca Jan 17, 2018
fc89cea
test: use countdown timer
daxlab Nov 26, 2017
b87939c
http: use strict comparison
leeseean Nov 14, 2017
74c1f4e
lib: fix typo in trace_events_async_hooks.js
gillesdemey Jan 21, 2018
17ef69e
doc: fix typo in async_hooks.md
ramesius Jan 22, 2018
195bed2
doc: use PBKDF2 in text
tniessen Jan 21, 2018
3543458
benchmark: (arrays) use destructuring
BridgeAR Dec 30, 2017
e00dac7
benchmark: (assert) use destructuring
BridgeAR Dec 30, 2017
aa47fe0
benchmark: (url) use destructuring
BridgeAR Dec 30, 2017
76f671b
benchmark: (zlib) use destructuring
BridgeAR Dec 30, 2017
c0707c5
benchmark: (util/v8/vm) use destructuring
BridgeAR Dec 30, 2017
3e3254a
benchmark: (tls) use destructuring
BridgeAR Dec 30, 2017
11d6458
benchmark: (timers) use destructuring
BridgeAR Dec 30, 2017
81abea5
benchmark: (streams) use destructuring
BridgeAR Dec 30, 2017
f491828
benchmark: (querystring) use destructuring
BridgeAR Dec 30, 2017
88f4bf2
benchmark: (process) use destructuring
BridgeAR Dec 30, 2017
cf666d8
benchmark: (net) use destructuring
BridgeAR Dec 30, 2017
7bc5bad
benchmark: (os) use destructuring
BridgeAR Dec 30, 2017
5b0e3b9
benchmark: (path) use destructuring
BridgeAR Dec 30, 2017
97e8820
benchmark: (string_decoder) use destructuring
BridgeAR Dec 30, 2017
d13d900
benchmark: (http2) use destructuring
BridgeAR Dec 30, 2017
e9c426b
benchmark: (misc) use destructuring
BridgeAR Dec 30, 2017
4e19cbe
benchmark: (http) use destructuring
BridgeAR Dec 30, 2017
59271c8
benchmark: (fs) use destructuring
BridgeAR Dec 30, 2017
c25d4d6
benchmark: (es) use destructuring
BridgeAR Dec 30, 2017
71faa5c
benchmark: (events) use destructuring
BridgeAR Dec 30, 2017
5cf5ab1
benchmark: (buffers) use destructuring
BridgeAR Dec 30, 2017
e19c77b
benchmark: (child_process) use destructuring
BridgeAR Dec 30, 2017
cd9bc8b
benchmark: (dgram) use destructuring
BridgeAR Dec 30, 2017
ea19f7d
benchmark: use destructuring
BridgeAR Dec 30, 2017
5855a57
test: change assert message to default
ryanmahan Jan 19, 2018
1efb9cd
doc: remove confusing signature in fs.md
vsemozhetbyt Jan 23, 2018
e3cc091
doc: add missing URL argument types in fs.md
vsemozhetbyt Jan 23, 2018
f050521
build: define NOMINMAX on windows
bnoordhuis Jan 23, 2018
485d60e
doc: fix typos in async_hooks
Jan 23, 2018
b055c9e
doc: split CONTRIBUTING.md
joyeecheung Jan 20, 2018
ce1eb0b
build: make lint-md independent of local node
joyeecheung Jan 20, 2018
2a9afc4
build: make lint-js independent of local node
joyeecheung Jan 20, 2018
693159e
deps: upgrade libuv to 1.19.1
cjihrig Jan 19, 2018
c9e09ad
doc: improve the instructions of onboarding PR
joyeecheung Jan 20, 2018
e5f6159
doc: document the collaborator nomination process
joyeecheung Jan 20, 2018
224cc64
doc: add doc for performance.clearGC()
antonyt Jan 23, 2018
987480c
doc: add missing word in modules.md
metapragma Jan 24, 2018
14f7f60
lib: add internal removeColors helper
BridgeAR Dec 11, 2017
f7d57d0
stream: remove unreachable code
lpinca Jan 18, 2018
7d27228
test: use correct size in test-stream-buffer-list
lpinca Jan 18, 2018
4d3121b
doc: fix return value for require.resolve.paths()
nephross Jan 24, 2018
574d3b9
doc: fix documentation of http2Stream.pushstream()
nephross Jan 19, 2018
39612a8
http2,perf_hooks: perf state using AliasedBuffer
kfarnung Jan 22, 2018
6ae7bb1
doc: fix e.g., to e.g. in docs
sreepurnajasti Jan 25, 2018
230a102
fs: cleanup fd lchown and lchownSync
jasnell Jan 23, 2018
1458e51
test: fix test-tls-server-verify.js on Windows CI
Trott Jan 25, 2018
c84dd03
test: refactor addons-napi/test_exception/test.js
Trott Jan 24, 2018
deac028
build: fix rm commands in tarball rule
bnoordhuis Jan 23, 2018
a5b35db
process: remove dead code
apapirovski Jan 23, 2018
ce7ce9d
process: clean up signal handler setup
apapirovski Jan 23, 2018
d829237
doc: fix typo in REPL docs
adamgoose Jan 26, 2018
7fc395a
http: there is no `corked` property of `stream`
indutny Jan 23, 2018
ecf5bea
src: remove unused variable
cjihrig Jan 25, 2018
03cb069
doc: unify type linkification
vsemozhetbyt Jan 27, 2018
7b73e70
timers: attach listOnTimeout function to TimerWrap
mcollina Jan 25, 2018
b5ec6ea
benchmark: make compare.R easier to understand
AndreasMadsen Jan 25, 2018
2efa7d1
benchmark: implement duration in http test double
joyeecheung Jan 25, 2018
84f8e62
src: DRY ip address parsing code in cares_wrap.cc
bnoordhuis Jan 26, 2018
799fd24
cluster: add cwd to cluster.settings
cjihrig Jan 26, 2018
3ab391d
src: remove unnecessary block scope
apapirovski Jan 21, 2018
144cfb4
src: remove outdated domain reference
apapirovski Jan 19, 2018
11982ae
process: JS fast path for bindings
apapirovski Jan 25, 2018
45051fa
doc: add vdeturckheim as collaborator
vdeturckheim Jan 29, 2018
117b20e
test: adds tests for vm invalid arguments
gillesdemey Jan 21, 2018
25bebae
stream: simplify `src._readableState` to `state`
Jan 20, 2018
c4abdcd
stream: avoid writeAfterEnd() while ending
Jan 16, 2018
0a68018
async_hooks: update defaultTriggerAsyncIdScope for perf
apapirovski Jan 5, 2018
ac2f98d
async_hooks,http: set HTTPParser trigger to socket
AndreasMadsen Jan 5, 2018
e9397d6
async_hooks,test: only use IPv6 in http test
AndreasMadsen Jan 14, 2018
5072454
2018-01-31, Version 9.5.0 (Current)
evanlucas Jan 30, 2018
81da708
Working on v9.5.1
evanlucas Feb 1, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: fix spelling in test case comments
PR-URL: #18018
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
  • Loading branch information
tniessen authored and evanlucas committed Jan 24, 2018
commit 5fccb6ea3a2e21e3aeb48359f58d068474873f65
4 changes: 2 additions & 2 deletions test/abort/test-http-parser-consume.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ if (process.argv[2] === 'child') {
const rr = get({ port: server.address().port }, common.mustCall(() => {
// This bad input (0) should abort the parser and the process
rr.parser.consume(0);
// This line should be unreachanble.
// This line should be unreachable.
assert.fail('this should be unreachable');
}));
}));
} else {
// super-proces
// super-process
const child = spawn(process.execPath, [__filename, 'child']);
child.stdout.on('data', common.mustNotCall());

Expand Down
2 changes: 1 addition & 1 deletion test/async-hooks/hook-checks.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ require('../common');
* @param {Object} activity including timestamps for each life time event,
* i.e. init, before ...
* @param {Object} hooks the expected life time event invocations with a count
* indicating how oftn they should have been invoked,
* indicating how often they should have been invoked,
* i.e. `{ init: 1, before: 2, after: 2 }`
* @param {String} stage the name of the stage in the test at which we are
* checking the invocations
Expand Down
2 changes: 1 addition & 1 deletion test/async-hooks/test-internal-nexttick-default-trigger.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
const common = require('../common');

// This tests ensures that the triggerId of both the internal and external
// nexTick function sets the triggerAsyncId correctly.
// nextTick function sets the triggerAsyncId correctly.

const assert = require('assert');
const async_hooks = require('async_hooks');
Expand Down
2 changes: 1 addition & 1 deletion test/async-hooks/test-pipeconnectwrap.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ function onlisten() {
const awaitOnconnectCalls = new Set(['server', 'client']);
function maybeOnconnect(source) {
// both server and client must call onconnect. On most OS's waiting for
// the client is sufficient, but on CertOS 5 the sever needs to respond too.
// the client is sufficient, but on CentOS 5 the sever needs to respond too.
assert.ok(awaitOnconnectCalls.size > 0);
awaitOnconnectCalls.delete(source);
if (awaitOnconnectCalls.size > 0) return;
Expand Down
2 changes: 1 addition & 1 deletion test/async-hooks/verify-graph.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ function pruneTickObjects(activities) {
foundTickObject = true;

// point all triggerAsyncIds that point to the tickObject
// to its triggerAsyncId and findally remove it from the activities
// to its triggerAsyncId and finally remove it from the activities
const tickObject = activities[tickObjectIdx];
const newTriggerId = tickObject.triggerAsyncId;
const oldTriggerId = tickObject.uid;
Expand Down
2 changes: 1 addition & 1 deletion test/common/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ if (process.env.NODE_TEST_WITH_ASYNC_HOOKS) {
const async_wrap = process.binding('async_wrap');

process.on('exit', () => {
// itterate through handles to make sure nothing crashes
// iterate through handles to make sure nothing crashes
for (const k in initHandles)
util.inspect(initHandles[k]);
});
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/net-fd-passing-receiver.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ receiver = net.createServer(function(socket) {
});
});

/* To signal the test runne we're up and listening */
/* To signal the test runner we're up and listening */
receiver.on('listening', function() {
console.log('ready');
});
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-async-hooks-http-agent.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const http = require('http');
// Checks that an http.Agent properly asyncReset()s a reused socket handle, and
// re-assigns the fresh async id to the reused `net.Socket` instance.

// Make sure a single socket is transpartently reused for 2 requests.
// Make sure a single socket is transparently reused for 2 requests.
const agent = new http.Agent({
keepAlive: true,
keepAliveMsecs: Infinity,
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-async-hooks-promise-enable-disable.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@ let p_inits = 0;
common.crashOnUnhandledRejection();

// Not useful to place common.mustCall() around 'exit' event b/c it won't be
// able to check it anway.
// able to check it anyway.
process.on('exit', (code) => {
if (code !== 0)
return;
if (p_er !== null)
throw p_er;
// Expecint exactly 2 PROMISE types to reach init.
// Expecting exactly 2 PROMISE types to reach init.
assert.strictEqual(p_inits, EXPECTED_INITS);
});

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-async-wrap-pop-id-during-load.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ if (process.argv[2] === 'async') {
throw new Error();
}
(async function() { await fn(); })();
// While the above should error, just in case it dosn't the script shouldn't
// While the above should error, just in case it doesn't the script shouldn't
// fork itself indefinitely so return early.
return;
}
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-buffer-fill.js
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ Buffer.alloc(8, '');
return 0;
} else {
elseWasLast = true;
// Once buffer.js calls the C++ implemenation of fill, return -1
// Once buffer.js calls the C++ implementation of fill, return -1
return -1;
}
}
Expand Down Expand Up @@ -405,7 +405,7 @@ common.expectsError(() => {
return 1;
} else {
elseWasLast = true;
// Once buffer.js calls the C++ implemenation of fill, return -1
// Once buffer.js calls the C++ implementation of fill, return -1
return -1;
}
}
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-buffer-includes.js
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ assert.strictEqual(
);


// test usc2 encoding
// test ucs2 encoding
let twoByteString = Buffer.from('\u039a\u0391\u03a3\u03a3\u0395', 'ucs2');

assert(twoByteString.includes('\u0395', 4, 'ucs2'));
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-buffer-indexof.js
Original file line number Diff line number Diff line change
Expand Up @@ -554,7 +554,7 @@ assert.strictEqual(511, longBufferString.lastIndexOf(pattern, 1534));
// "yolo swag swag yolo swag yolo yolo swag" ..., goes on for about 5MB.
// This is hard to search because it all looks similar, but never repeats.

// countBits returns the number of bits in the binary reprsentation of n.
// countBits returns the number of bits in the binary representation of n.
function countBits(n) {
let count;
for (count = 0; n > 0; count++) {
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-buffer-read.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@ function read(buff, funx, args, expected) {

}

// testing basic functionality of readDoubleBE() and readDOubleLE()
// testing basic functionality of readDoubleBE() and readDoubleLE()
read(buf, 'readDoubleBE', [1], -3.1827727774563287e+295);
read(buf, 'readDoubleLE', [1], -6.966010051009108e+144);

// testing basic functionality of readFLoatBE() and readFloatLE()
// testing basic functionality of readFloatBE() and readFloatLE()
read(buf, 'readFloatBE', [1], -1.6691549692541768e+37);
read(buf, 'readFloatLE', [1], -7861303808);

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-child-process-internal.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ if (process.argv[2] === 'child') {
//send non-internal message containing PREFIX at a non prefix position
process.send(normal);

//send inernal message
//send internal message
process.send(internal);

process.exit(0);
Expand Down
8 changes: 4 additions & 4 deletions test/parallel/test-child-process-send-returns-boolean.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const fixtures = require('../common/fixtures');
const subScript = fixtures.path('child-process-persistent.js');

{
// Test `send` return value on `fork` that opens and IPC by deafult.
// Test `send` return value on `fork` that opens and IPC by default.
const n = fork(subScript);
// `subprocess.send` should always return `true` for the first send.
const rv = n.send({ h: 'w' }, (err) => { if (err) assert.fail(err); });
Expand All @@ -31,12 +31,12 @@ const subScript = fixtures.path('child-process-persistent.js');
const server = net.createServer(common.mustNotCall()).listen(0, () => {
const handle = server._handle;

// Sending a handle and not giving the tickQueue time to acknoladge should
// Sending a handle and not giving the tickQueue time to acknowledge should
// create the internal backlog, but leave it empty.
const rv1 = s.send('one', handle, (err) => { if (err) assert.fail(err); });
assert.strictEqual(rv1, true);
// Since the first `send` included a handle (should be unackoladged),
// we can safly queue up only one more message.
// Since the first `send` included a handle (should be unacknowledged),
// we can safely queue up only one more message.
const rv2 = s.send('two', (err) => { if (err) assert.fail(err); });
assert.strictEqual(rv2, true);
// The backlog should now be indicate to backoff.
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-crypto-deprecated.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ common.expectWarning('DeprecationWarning', [

// Accessing the deprecated function is enough to trigger the warning event.
// It does not need to be called. So the assert serves the purpose of both
// triggering the warning event and confirming that the deprected function is
// triggering the warning event and confirming that the deprecated function is
// mapped to the correct non-deprecated function.
assert.strictEqual(crypto.Credentials, tls.SecureContext);
assert.strictEqual(crypto.createCredentials, tls.createSecureContext);
2 changes: 1 addition & 1 deletion test/parallel/test-crypto-fips.js
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ testHelper(
// to try to call the fips setter, to try to detect this situation, as
// that would throw an error:
// ("Error: Cannot set FIPS mode in a non-FIPS build.").
// Due to this uncertanty the following tests are skipped when configured
// Due to this uncertainty the following tests are skipped when configured
// with --shared-openssl.
if (!sharedOpenSSL()) {
// OpenSSL config file should be able to turn on FIPS mode
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ if (process.argv[2] === 'child') {
// is not properly flushed in V8's Isolate::Throw right before the
// process aborts due to an uncaught exception, and thus the error
// message representing the error that was thrown cannot be read by the
// parent process. So instead of parsing the child process' stdandard
// parent process. So instead of parsing the child process' standard
// error, the parent process will check that in the case
// --abort-on-uncaught-exception was passed, the process did not exit
// with exit code RAN_UNCAUGHT_EXCEPTION_HANDLER_EXIT_CODE.
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-event-emitter-remove-listeners.js
Original file line number Diff line number Diff line change
Expand Up @@ -119,10 +119,10 @@ function listener2() {}

// listener4 will still be called although it is removed by listener 3.
ee.emit('hello');
// This is so because the interal listener array at time of emit
// This is so because the internal listener array at time of emit
// was [listener3,listener4]

// Interal listener array [listener3]
// Internal listener array [listener3]
ee.emit('hello');
}

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-fs-access.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ createFileWithPerms(readWriteFile, 0o666);
* The change of user id is done after creating the fixtures files for the same
* reason: the test may be run as the superuser within a directory in which
* only the superuser can create files, and thus it may need superuser
* priviledges to create them.
* privileges to create them.
*
* There's not really any point in resetting the process' user id to 0 after
* changing it to 'nobody', since in the case that the test runs without
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-fs-read-stream-double-close.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const fs = require('fs');
{
const s = fs.createReadStream(__filename);

// this is a private API, but it is worth esting. close calls this
// this is a private API, but it is worth testing. close calls this
s.destroy(null, common.mustCall());
s.destroy(null, common.mustCall());
}
4 changes: 2 additions & 2 deletions test/parallel/test-http-agent-keepalive.js
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ function remoteClose() {
process.nextTick(common.mustCall(() => {
assert.strictEqual(agent.sockets[name], undefined);
assert.strictEqual(agent.freeSockets[name].length, 1);
// waitting remote server close the socket
// waiting remote server close the socket
setTimeout(common.mustCall(() => {
assert.strictEqual(agent.sockets[name], undefined);
assert.strictEqual(agent.freeSockets[name], undefined,
Expand All @@ -102,7 +102,7 @@ function remoteClose() {
}

function remoteError() {
// remove server will destroy ths socket
// remote server will destroy the socket
const req = get('/error', common.mustNotCall());
req.on('error', common.mustCall((err) => {
assert(err);
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-http-extra-response.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ const server = net.createServer(function(socket) {

if (postBody.includes('\r\n')) {
socket.write(fullResponse);
// omg, I wrote the response twice, what a terrible HTTP server I am.
socket.end(fullResponse);
}
});
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-http2-server-push-disabled.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ server.listen(0, common.mustCall(() => {
options);
const req = client.request({ ':path': '/' });

// Because push stream sre disabled, this must not be called.
// Because push streams are disabled, this must not be called.
client.on('stream', common.mustNotCall());

req.resume();
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-http2-server-timeout.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@ server.once('timeout', onServerTimeout);
server.listen(0, common.mustCall(() => {
const url = `http://localhost:${server.address().port}`;
const client = http2.connect(url);
// Because of the timeout, an ECONRESET error may or may not happen here.
// Because of the timeout, an ECONNRESET error may or may not happen here.
// Keep this as a non-op and do not use common.mustCall()
client.on('error', () => {});
client.on('close', common.mustCall(() => {
const client2 = http2.connect(url);
// Because of the timeout, an ECONRESET error may or may not happen here.
// Because of the timeout, an ECONNRESET error may or may not happen here.
// Keep this as a non-op and do not use common.mustCall()
client2.on('error', () => {});
client2.on('close', common.mustCall(() => server.close()));
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-http2-too-many-streams.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ server.on('stream', common.mustCall((stream) => {
// c should never be greater than 1.
assert.strictEqual(++c, 1);
stream.respond();
// Force some asynchronos stuff.
// Force some asynchronous stuff.
setImmediate(() => {
stream.end('ok');
assert.strictEqual(--c, 0);
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-https-agent-secure-protocol.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ server.listen(0, common.mustCall(function() {
}, common.mustCall(function(res) {
res.resume();
globalAgent.once('free', common.mustCall(function() {
// Verify that two keep-alived connections are created
// Verify that two keep-alive connections are created
// due to the different secureProtocol settings:
const keys = Object.keys(globalAgent.freeSockets);
assert.strictEqual(keys.length, 2);
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-https-socket-options.js
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ server_http.listen(0, function() {
});

// Then try https server (requires functions to be
// mirroed in tls.js's CryptoStream)
// mirrored in tls.js's CryptoStream)

const server_https = https.createServer(options, function(req, res) {
console.log('got HTTPS request');
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-internal-fs-syncwritestream.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ const filename = path.join(common.tmpDir, 'sync-write-stream.txt');
assert.strictEqual(stream.listenerCount('end'), 1);
}

// Verfiy that the file will be written synchronously.
// Verify that the file will be written synchronously.
{
const fd = fs.openSync(filename, 'w');
const stream = new SyncWriteStream(fd);
Expand All @@ -54,7 +54,7 @@ const filename = path.join(common.tmpDir, 'sync-write-stream.txt');
assert.strictEqual(stream.destroySoon(), true);
}

// Verfit that the 'end' event listener will also destroy the stream.
// Verify that the 'end' event listener will also destroy the stream.
{
const fd = fs.openSync(filename, 'w');
const stream = new SyncWriteStream(fd);
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-net-listen-error.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,5 @@ const net = require('net');

const server = net.createServer(function(socket) {
});
server.listen(1, '1.1.1.1', common.mustNotCall()); // EACCESS or EADDRNOTAVAIL
server.listen(1, '1.1.1.1', common.mustNotCall()); // EACCES or EADDRNOTAVAIL
server.on('error', common.mustCall());
2 changes: 1 addition & 1 deletion test/parallel/test-net-pipe-connect-errors.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ if (common.isWindows) {
emptyTxt = fixtures.path('empty.txt');
} else {
common.refreshTmpDir();
// Keep the file name very short so tht we don't exceed the 108 char limit
// Keep the file name very short so that we don't exceed the 108 char limit
// on CI for a POSIX socket. Even though this isn't actually a socket file,
// the error will be different from the one we are expecting if we exceed the
// limit.
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-net-write-after-close.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ const server = net.createServer(common.mustCall(function(socket) {

server.listen(0, function() {
const client = net.connect(this.address().port, function() {
// cliend.end() will close both the readable and writable side
// client.end() will close both the readable and writable side
// of the duplex because allowHalfOpen defaults to false.
// Then 'end' will be emitted when it receives a FIN packet from
// the other side.
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-os.js
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ is.string(arch);
assert.ok(arch.length > 0);

if (!common.isSunOS) {
// not implemeneted yet
// not implemented yet
assert.ok(os.loadavg().length > 0);
assert.ok(os.freemem() > 0);
assert.ok(os.totalmem() > 0);
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-promises-unhandled-rejections.js
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ asyncTest('While inside setImmediate, catching a rejected promise derived ' +
});
});

// State adapation tests
// State adaptation tests
asyncTest('catching a promise which is asynchronously rejected (via ' +
'resolution to an asynchronously-rejected promise) prevents' +
' unhandledRejection', function(done) {
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-readline-interface.js
Original file line number Diff line number Diff line change
Expand Up @@ -808,7 +808,7 @@ function isWarned(emitter) {
assert.strictEqual(isWarned(process.stdout._events), false);
}

// can create a new readline Interface with a null output arugument
// can create a new readline Interface with a null output argument
{
const fi = new FakeInput();
const rli = new readline.Interface(
Expand Down
Loading