Skip to content

benchmark: shorten config name in http benchmark #18452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 2 commits into from
Closed

benchmark: shorten config name in http benchmark #18452

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
953c941
benchmark: shorten config name in http benchmark
joyeecheung Jan 30, 2018
d317a76
squash! use triple equals
joyeecheung Feb 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions benchmark/http/check_invalid_header_char.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
const common = require('../common.js');
const _checkInvalidHeaderChar = require('_http_common')._checkInvalidHeaderChar;

// Put it here so the benchmark result lines will not be super long.
const LONG_AND_INVALID = 'Here is a value that is really a folded header ' +
'value\r\n this should be \supported, but it is not currently';

const bench = common.createBenchmark(main, {
key: [
// Valid
Expand All @@ -21,8 +25,7 @@ const bench = common.createBenchmark(main, {
'en-US',

// Invalid
'Here is a value that is really a folded header value\r\n this should be \
supported, but it is not currently',
'LONG_AND_INVALID',
'中文呢', // unicode
'foo\nbar',
'\x7F'
Expand All @@ -31,6 +34,9 @@ const bench = common.createBenchmark(main, {
});

function main({ n, key }) {
if (key == 'LONG_AND_INVALID') {
Copy link
Copy Markdown
Member

@lpinca lpinca Jan 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: ===

key = LONG_AND_INVALID;
}
bench.start();
for (var i = 0; i < n; i++) {
_checkInvalidHeaderChar(key);
Expand Down