Skip to content

backport 18250 to v9.x #18304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 24 commits into from
Closed

backport 18250 to v9.x #18304

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
aa6fdf1
benchmark: (arrays) use destructuring
BridgeAR Dec 30, 2017
52cfd34
benchmark: (assert) use destructuring
BridgeAR Dec 30, 2017
a47b478
benchmark: (url) use destructuring
BridgeAR Dec 30, 2017
d6d4b6b
benchmark: (zlib) use destructuring
BridgeAR Dec 30, 2017
e032fee
benchmark: (util/v8/vm) use destructuring
BridgeAR Dec 30, 2017
67d158c
benchmark: (tls) use destructuring
BridgeAR Dec 30, 2017
69e7083
benchmark: (timers) use destructuring
BridgeAR Dec 30, 2017
c84762f
benchmark: (streams) use destructuring
BridgeAR Dec 30, 2017
e841268
benchmark: (querystring) use destructuring
BridgeAR Dec 30, 2017
ae5a06f
benchmark: (process) use destructuring
BridgeAR Dec 30, 2017
15c3b26
benchmark: (net) use destructuring
BridgeAR Dec 30, 2017
8bfa3af
benchmark: (os) use destructuring
BridgeAR Dec 30, 2017
b4609ab
benchmark: (path) use destructuring
BridgeAR Dec 30, 2017
62976e0
benchmark: (string_decoder) use destructuring
BridgeAR Dec 30, 2017
7e0df93
benchmark: (http2) use destructuring
BridgeAR Dec 30, 2017
c56feec
benchmark: (misc) use destructuring
BridgeAR Dec 30, 2017
a0b8fa3
benchmark: (http) use destructuring
BridgeAR Dec 30, 2017
9473627
benchmark: (fs) use destructuring
BridgeAR Dec 30, 2017
c3adef5
benchmark: (es) use destructuring
BridgeAR Dec 30, 2017
7a7ecad
benchmark: (events) use destructuring
BridgeAR Dec 30, 2017
f90cd1d
benchmark: (buffers) use destructuring
BridgeAR Dec 30, 2017
d746d5a
benchmark: (child_process) use destructuring
BridgeAR Dec 30, 2017
171a010
benchmark: (dgram) use destructuring
BridgeAR Dec 30, 2017
3a99ff9
benchmark: use destructuring
BridgeAR Dec 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
benchmark: (zlib) use destructuring 
PR-URL: #18250
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
@BridgeAR
BridgeAR committed Jan 23, 2018
commit d6d4b6b8e5437b86d73d8342fb30425c4a918906
7 changes: 3 additions & 4 deletions benchmark/zlib/creation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,13 @@ const bench = common.createBenchmark(main, {
n: [5e5]
});

function main(conf) {
const n = +conf.n;
const fn = zlib[`create${conf.type}`];
function main({ n, type, options }) {
const fn = zlib[`create${type}`];
if (typeof fn !== 'function')
throw new Error('Invalid zlib type');
var i = 0;

if (conf.options === 'true') {
if (options === 'true') {
const opts = {};
bench.start();
for (; i < n; ++i)
Expand Down
6 changes: 2 additions & 4 deletions benchmark/zlib/deflate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,8 @@ const bench = common.createBenchmark(main, {
n: [4e5]
});

function main(conf) {
const n = +conf.n;
const method = conf.method;
const chunk = Buffer.alloc(+conf.inputLen, 'a');
function main({ n, method, inputLen }) {
const chunk = Buffer.alloc(inputLen, 'a');

var i = 0;
switch (method) {
Expand Down