Skip to content

doc: document the collaborator nomination process #18268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 5 commits into from
Closed

doc: document the collaborator nomination process #18268

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5ba2c04
doc: improve the instructions of onboarding PR
joyeecheung Jan 20, 2018
acbdfd7
doc: document the collaborator nomination process
joyeecheung Jan 20, 2018
81c6801
fixup! avoid ambiguity in pronouns
joyeecheung Jan 20, 2018
037976a
fixup! fix broken link in onboarding.md
joyeecheung Jan 22, 2018
6424d8c
improve phrasing, capitalize Collaborator
joyeecheung Jan 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
doc: improve the instructions of onboarding PR
  • Loading branch information
@joyeecheung
joyeecheung committed Jan 20, 2018
commit 5ba2c04a5c2831d6237f4752d69a1038c9f48c2f
12 changes: 7 additions & 5 deletions doc/onboarding.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,12 +199,13 @@ onboarding session.
* Optionally, include your personal pronouns.
* Label your pull request with the `doc` subsystem label.
* Run CI on your PR.
* After one or two approvals, land the PR.
* After one or two approvals, land the PR (PRs of this type do not need to wait
for 48/72 hours to land).
* Be sure to add the `PR-URL: <full-pr-url>` and appropriate `Reviewed-By:`
metadata!
* [`core-validate-commit`][] helps a lot with this – install and use it if you
can!
* [`node-core-utils`][] fetches the metadata for you.
metadata.
* [`core-validate-commit`][] automates the validation of commit messages.
* [`node-core-utils`][] automates the generation of metadata and the landing
process. See the documentation of [git-node][].
Copy link
Copy Markdown
Member Author

@joyeecheung joyeecheung Jan 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, broken link (no backticks). Will fix it later.


## Final notes

Expand All @@ -227,6 +228,7 @@ onboarding session.

[Code of Conduct]: https://github.com/nodejs/admin/blob/master/CODE_OF_CONDUCT.md
[`core-validate-commit`]: https://github.com/evanlucas/core-validate-commit
[`git-node`]: https://github.com/nodejs/node-core-utils#git-node
[`node-core-utils`]: https://github.com/nodejs/node-core-utils
[Landing Pull Requests]: https://github.com/nodejs/node/blob/master/COLLABORATOR_GUIDE.md#landing-pull-requests
[https://github.com/nodejs/node/commit/ce986de829457c39257cd205067602e765768fb0]: https://github.com/nodejs/node/commit/ce986de829457c39257cd205067602e765768fb0
Expand Down