Skip to content

fix flaky net-connect-handle-econnrefused #18257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Leko wants to merge 2 commits into from
Closed

fix flaky net-connect-handle-econnrefused #18257

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5965e5
test: try to connect after server was closed
Leko Jan 19, 2018
515e7d8
test: wrap callback in common.mustCall
Leko Jan 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: wrap callback in common.mustCall
  • Loading branch information
@Leko
Leko committed Jan 20, 2018
commit 515e7d80f4991328a33deaf6999b3e1ec3ca1d73
4 changes: 2 additions & 2 deletions test/parallel/test-net-connect-handle-econnrefused.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ const assert = require('assert');
const server = net.createServer();
server.listen(0);
const port = server.address().port;
server.close(() => {
server.close(common.mustCall(() => {
const c = net.createConnection(port);
c.on('connect', common.mustNotCall());
c.on('error', common.mustCall((e) => {
assert.strictEqual('ECONNREFUSED', e.code);
}));
});
}));