Skip to content

stream: readable stream should not push undefined in non-objectMode #18244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MoonBall wants to merge 2 commits into from
Closed

stream: readable stream should not push undefined in non-objectMode #18244

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19090ac
stream: readable stream should not push undefined in non-objectMode
Jan 19, 2018
a186f78
Add a test case
Jan 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
stream: readable stream should not push undefined in non-objectMode
  • Loading branch information
陈刚 committed Jan 21, 2018
commit 19090ac10649c7eb595bfbb521dfb14cf8b9f4a6
1 change: 0 additions & 1 deletion lib/_stream_readable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,6 @@ function chunkInvalid(state, chunk) {
var er;
if (!Stream._isUint8Array(chunk) &&
typeof chunk !== 'string' &&
chunk !== undefined &&
!state.objectMode) {
er = new errors.TypeError('ERR_INVALID_ARG_TYPE',
'chunk', ['string', 'Buffer', 'Uint8Array']);
Expand Down