Skip to content

n-api: add methods to open/close callback scope #18089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mhdawson wants to merge 3 commits into from
Closed

n-api: add methods to open/close callback scope #18089

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a0f4492
n-api: add methods to open/close callback scope
mhdawson Dec 13, 2017
e9200b4
squash: address comments
mhdawson Feb 5, 2018
a1ea4c8
squash: fix valgrind warnings
mhdawson Feb 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
squash: address comments
  • Loading branch information
@mhdawson
mhdawson committed Feb 5, 2018
commit e9200b41957c35f4d774468ee97d3c00145329ea
6 changes: 3 additions & 3 deletions test/addons-napi/test_callback_scope/binding.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ napi_value RunInCallbackScope(napi_env env, napi_callback_info info) {
napi_value args[4];

NAPI_CALL(env, napi_get_cb_info(env, info, &argc, nullptr, nullptr, nullptr));
NAPI_ASSERT(env, argc ==4 , "Wrong number of arguments");
NAPI_ASSERT(env, argc == 4 , "Wrong number of arguments");

NAPI_CALL(env, napi_get_cb_info(env, info, &argc, args, nullptr, nullptr));

Expand Down Expand Up @@ -112,7 +112,7 @@ napi_value TestResolveAsync(napi_env env, napi_callback_info info) {
uv_loop_t* loop = nullptr;
NAPI_CALL(env, napi_get_uv_event_loop(env, &loop));

uv_work_t* req = new uv_work_t;
uv_work_t* req = new uv_work_t();
uv_queue_work(loop,
req,
[](uv_work_t*) {},
Expand All @@ -133,6 +133,6 @@ napi_value Init(napi_env env, napi_value exports) {
return exports;
}

} // namespace
} // anonymous namespace

NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)