Skip to content

Process 100, 102-199 status codes according to specs. #18033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
miles-po wants to merge 20 commits into from
Closed

Process 100, 102-199 status codes according to specs. #18033

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
5200fab
Process 100, 102-199 status codes according to specs.
Jan 8, 2018
fba79a8
Cleaning up status code comment to be clearer.
Jan 8, 2018
58bb0ca
Cleaning up code to reuse informational status check.
Jan 8, 2018
79301fa
Fine tuning comment change.
Jan 8, 2018
b2c81fc
Renamed 'informational' function to be more explicit.
Jan 8, 2018
fd33e98
Firing event for information messages
Feb 4, 2018
2113f0a
Adding writeInformation to handle 1xx status codes
Feb 4, 2018
65405c4
Adding 102 Processing test
Feb 4, 2018
ea72928
Renaming 102 status test
Feb 4, 2018
29cae69
Added test for 103 Early Hints
Feb 4, 2018
5f4049c
Making a record
Feb 4, 2018
d7bacbb
Dropped 103+ and concentrated on 102 Processing
Feb 4, 2018
12e0566
Capitalized comment and added comments for context
Feb 4, 2018
e51c7ae
Addressing notes by @mcollina
Feb 5, 2018
0386a11
Updated docs to clarify and show usage
Feb 10, 2018
e46b997
Fixed line length
Feb 10, 2018
130e729
Removed HTTP/2 doc updates
Feb 12, 2018
89e4552
Fixed rebase errors and nits
Feb 12, 2018
1eee678
Unwrapped redundant mustCall(...)
Feb 12, 2018
1c2e86d
Fixed markdown typo; removed warning
Feb 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Cleaning up status code comment to be clearer.
  • Loading branch information
Miles Elam committed Feb 10, 2018
commit fba79a8a66396b20eb1ab2b70e650f2e9bb1d3f8
5 changes: 3 additions & 2 deletions lib/_http_client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,8 +450,9 @@ function socketOnData(d) {
// When the status code is 100 (Continue), 102 (Processing),
// 103 (Early Hints), or 104-199 (Unassigned), the server will
// send a final response after this client sends a request
// body. 101 (Switching Protocols) and all other status codes
// should be handled separately. So, we must not free the parser.
// body, so we must not free the parser.
// 101 (Switching Protocols) and all other status codes
// should be processed normally.
(parser.incoming.statusCode >= 200 ||
parser.incoming.statusCode === 101)) {
socket.removeListener('data', socketOnData);
Expand Down