Skip to content

src: refactor HasWriteQueue() away #18019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 3 commits into from
Closed

src: refactor HasWriteQueue() away #18019

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b0fd7a
process: use more direct sync I/O for stdio
addaleax Dec 30, 2017
fad18b4
src: remove `HasWriteQueue()`
addaleax Dec 30, 2017
72ff460
src: use `DoTryWrite()` for not-all-Buffer writev()s too
addaleax Jan 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
src: use DoTryWrite() for not-all-Buffer writev()s too
  • Loading branch information
@addaleax
addaleax committed Jan 10, 2018
commit 72ff4605e476e2b810bf8cbe0c11e6cb7616b01e
7 changes: 7 additions & 0 deletions src/stream_base.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,13 @@ int StreamBase::Writev(const FunctionCallbackInfo<Value>& args) {
offset += str_size;
bytes += str_size;
}

err = DoTryWrite(&buf_list, &count);
if (err != 0 || count == 0) {
req_wrap->Dispatched();
req_wrap->Dispose();
goto done;
}
}

err = DoWrite(req_wrap, buf_list, count, nullptr);
Expand Down