Skip to content

test: fix flaky test-http-highwatermark #17949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
apapirovski wants to merge 2 commits into from
Closed

test: fix flaky test-http-highwatermark #17949

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2531d5
test: fix flaky test-http-highwatermark
apapirovski Jan 2, 2018
1408c3f
fixup: nits
apapirovski Jan 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: fix flaky test-http-highwatermark
  • Loading branch information
@apapirovski
apapirovski committed Jan 2, 2018
commit c2531d53286d2d5be4f58bd44fcacf96ba056057
6 changes: 3 additions & 3 deletions test/parallel/test-http-hightwatermark.js → test/parallel/test-http-highwatermark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ let requestReceived = 0;
const server = http.createServer(function(req, res) {
const id = ++requestReceived;
const enoughToDrain = req.connection.writableHighWaterMark;
const body = 'x'.repeat(enoughToDrain);
const body = 'x'.repeat(enoughToDrain * 100);

if (id === 1) {
// Case of needParse = false
Expand All @@ -39,11 +39,11 @@ const server = http.createServer(function(req, res) {
}).on('listening', () => {
const c = net.createConnection(server.address().port, () => {
c.write('GET / HTTP/1.1\r\n\r\n');
c.write('GET / HTTP/1.1\r\n\r\n');
c.write('GET / HTTP/1.1\r\n\r\n',
() => setImmediate(() => c.on('data', () => {})));
Copy link
Copy Markdown
Member

@lpinca lpinca Jan 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: c.resume()? It removes the noop.

c.end();
});

c.on('data', () => {});
c.on('end', () => {
server.close();
});
Expand Down