Skip to content

tools: eslint rule to disallow Unicode quotes #17934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SirR4T wants to merge 2 commits into from
Closed

tools: eslint rule to disallow Unicode quotes #17934

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92d18fe
tools: eslint rule to disallow Unicode quotes
Jan 1, 2018
9ffa931
tools: Disabling eslint rule for failing tests
Jan 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
tools: eslint rule to disallow Unicode quotes 
Fixes: #11209
  • Loading branch information
Sarat Addepalli committed Jan 4, 2018
commit 92d18fe82dafad6e4b0a57e9c61b79b04cabfbe3
6 changes: 6 additions & 0 deletions .eslintrc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,12 @@ rules:
}, {
selector: "ThrowStatement > CallExpression[callee.name=/Error$/]",
message: "Use new keyword when throwing an Error."
}, {
selector: "Literal[value=/\u2019/]",
message: "use an ASCII single quote (`'`) instead of a Unicode quote (`\u2019`)"
}, {
selector: "Literal[value=/[“”«»]/]",
message: "use an ASCII double quote (`\"`) instead of a Unicode double quote (`“`, `”`, `«`, `»`)"
}]
no-tabs: error
no-trailing-spaces: error
Expand Down