Skip to content

doc: added articles about PR communication in CONTRIBUTING.md #17902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SalameWilliam wants to merge 3 commits into from
Closed

doc: added articles about PR communication in CONTRIBUTING.md #17902

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1fb9fd7
doc: added articles about PR communication in CONTRIBUTING.md
Dec 28, 2017
670ddfd
doc: fixed a forgotten comma
Dec 28, 2017
4ced007
doc: moved links about PR communication to COLLABORATOR_GUIDE.md
Dec 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
doc: moved links about PR communication to COLLABORATOR_GUIDE.md 
Moved a few links about PR communication from CONTRIBUTING.md
to COLLABORATOR_GUIDE.md
  • Loading branch information
Salame William committed Dec 29, 2017
commit 4ced00784b2f6c832a3a068c54df4cf3e95bf2b4
5 changes: 5 additions & 0 deletions COLLABORATOR_GUIDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,11 @@ oppose the PR, it can be landed. Where there is disagreement among TSC members
or objections from one or more Collaborators, `semver-major` pull requests
should be put on the TSC meeting agenda.

#### Helpful resources

* How to respectfully and usefully review code, part [one](https://mtlynch.io/human-code-reviews-1/) and [two](https://mtlynch.io/human-code-reviews-2/)
* [How to write a positive code review](https://css-tricks.com/code-review-etiquette/)

### Waiting for Approvals

Before landing pull requests, sufficient time should be left for input
Expand Down
2 changes: 0 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -828,8 +828,6 @@ The following additional resources may be of assistance:
* [How to create a Minimal, Complete, and Verifiable example](https://stackoverflow.com/help/mcve)
* [core-validate-commit](https://github.com/evanlucas/core-validate-commit) -
A utility that ensures commits follow the commit formatting guidelines.
* How to respectfully and usefully review code, part [one](https://mtlynch.io/human-code-reviews-1/) and [two](https://mtlynch.io/human-code-reviews-2/)
* [How to write a positive code review](https://css-tricks.com/code-review-etiquette/)

<a id="developers-certificate-of-origin"></a>
## Developer's Certificate of Origin 1.1
Expand Down