Skip to content

tools: enable array-callback-return ESLint rule #17858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 3 commits into from
+12 −13
Closed

tools: enable array-callback-return ESLint rule #17858

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d018b7b
readline: refactor filter() callback
Trott Dec 25, 2017
5817019
test: replace map() with forEach() where appropriate
Trott Dec 25, 2017
22a5f05
tools: enable array-callback-return ESLint rule
Trott Dec 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
readline: refactor filter() callback 
Use construct that always returns a boolean for `filter()` callback.
  • Loading branch information
@Trott
Trott committed Dec 27, 2017
commit d018b7bf63186c981d1fb68853d29d9437eb0956
4 changes: 1 addition & 3 deletions lib/readline.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,9 +500,7 @@ Interface.prototype._tabComplete = function(lastKeypressWasTab) {
}

// If there is a common prefix to all matches, then apply that portion.
var f = completions.filter(function completionFilter(e) {
if (e) return e;
});
var f = completions.filter((e) => e);
var prefix = commonPrefix(f);
if (prefix.length > completeOn.length) {
self._insertString(prefix.slice(completeOn.length));
Expand Down