Skip to content

test: do not open fixture files for writing #17808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 1 commit into from
Closed

test: do not open fixture files for writing #17808

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: do not open fixture files for writing 
test-fs-fsync makes a copy of a fixture file, but then doesn't do
anything with it and instead operates on the original fixture file. This
appears to be in error, and this change fixes that.
  • Loading branch information
@Trott
Trott committed Dec 21, 2017
commit 1de94554ab4049f28881f9e88602f9662d2d37a8
2 changes: 1 addition & 1 deletion test/parallel/test-fs-fsync.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ const fileTemp = path.join(common.tmpDir, 'a.js');
common.refreshTmpDir();
fs.copyFileSync(fileFixture, fileTemp);

fs.open(fileFixture, 'a', 0o777, common.mustCall(function(err, fd) {
fs.open(fileTemp, 'a', 0o777, common.mustCall(function(err, fd) {
assert.ifError(err);

fs.fdatasyncSync(fd);
Expand Down