Skip to content

async_hooks: use typed array stack as fast path #17780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 4 commits into from
Closed

async_hooks: use typed array stack as fast path #17780

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d84f16e
src: use async_context instead of custom struct
addaleax Dec 19, 2017
6bed72a
async_hooks: use typed array stack as fast path
addaleax Dec 20, 2017
12c10d1
[squash] switch to resizable typed array
addaleax Dec 21, 2017
24c80e7
[squash] bnoordhuis comments
addaleax Dec 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
src: use async_context instead of custom struct
  • Loading branch information
@addaleax
addaleax committed Dec 20, 2017
commit d84f16eba76bf256754fd0d42dba2490496e68f2
7 changes: 1 addition & 6 deletions src/env.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,11 +313,6 @@ class ModuleWrap;

class Environment;

struct node_async_ids {
double async_id;
double trigger_async_id;
};

class IsolateData {
public:
IsolateData(v8::Isolate* isolate, uv_loop_t* event_loop,
Expand Down Expand Up @@ -424,7 +419,7 @@ class Environment {
// Used by provider_string().
v8::Isolate* isolate_;
// Stores the ids of the current execution context stack.
std::stack<struct node_async_ids> async_ids_stack_;
std::stack<async_context> async_ids_stack_;
// Attached to a Uint32Array that tracks the number of active hooks for
// each type.
AliasedBuffer<uint32_t, v8::Uint32Array> fields_;
Expand Down