Skip to content

net: migrate errors to internal/errors #17766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kysnm wants to merge 7 commits into from
Closed

net: migrate errors to internal/errors #17766

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0419699
net: migrate errors to internal/errors
kysnm Dec 19, 2017
614792b
Wrap at 80 chars
kysnm Dec 20, 2017
9f60c2c
`Server` should be enclosed to backticks
kysnm Dec 20, 2017
4f79622
Just an adjustment
kysnm Dec 20, 2017
37711dd
Use common.expectsError instead of assert.strictEqual
kysnm Dec 20, 2017
7832c2f
Remove useless common.mustCall
kysnm Dec 20, 2017
3cf5f8f
Remove useless common.mustCall again
kysnm Dec 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Wrap at 80 chars
  • Loading branch information
@kysnm
kysnm committed Dec 20, 2017
commit 614792bf4f7c7dc5f5fbbbc7cfbe1c28b5c19707
3 changes: 2 additions & 1 deletion doc/api/errors.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1358,7 +1358,8 @@ and HTTP/2 Server instances.
<a id="ERR_SERVER_NOT_RUNNING"></a>
### ERR_SERVER_NOT_RUNNING

The [`server.close()`][] method was called when a `net.Server` was not running. This applies to all instances of `net.Server`, including HTTP, HTTPS,
The [`server.close()`][] method was called when a `net.Server` was not running.
This applies to all instances of `net.Server`, including HTTP, HTTPS,
and HTTP/2 Server instances.
Copy link
Copy Markdown
Member

@Trott Trott Dec 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: "Server" should probably be either in backticks or else lowercase. (Either it is referring to a server generically, in which case lowercase, or it is referring to the Server object, in which case backticks.)


<a id="ERR_SOCKET_ALREADY_BOUND"></a>
Expand Down