Skip to content

tools: fix man pages linking regex #17724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DiegoRBaquero wants to merge 4 commits into from
Closed

tools: fix man pages linking regex #17724

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5af4822
tools: fix man pages linking regex
DiegoRBaquero Dec 18, 2017
fa42177
tools: fix man pages linking regex
DiegoRBaquero Dec 19, 2017
b849956
tools: remove space in man pages returned link
DiegoRBaquero Dec 19, 2017
34a9db0
tools: move beginning regex matching group
DiegoRBaquero Dec 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tools: remove space in man pages returned link
  • Loading branch information
@DiegoRBaquero
DiegoRBaquero authored Dec 19, 2017
commit b8499564953c1175356862142f5803101cbde5a4
4 changes: 2 additions & 2 deletions tools/doc/html.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,10 +421,10 @@ function linkManPages(text) {
// name consists of lowercase letters, number is a single digit
const displayAs = `${beginning}${name}(${number}${optionalCharacter})`;
if (BSD_ONLY_SYSCALLS.has(name)) {
return ` <a href="https://www.freebsd.org/cgi/man.cgi?query=${name}` +
return `<a href="https://www.freebsd.org/cgi/man.cgi?query=${name}` +
Copy link
Copy Markdown
Member

@lpinca lpinca Dec 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think beginning should be used here, replacing the space.

Copy link
Copy Markdown
Member

@Trott Trott Dec 19, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lpinca Same applies to line 427 too? Or am I mistaken about that?

Copy link
Copy Markdown
Member

@lpinca lpinca Dec 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that's correct.

`&sektion=${number}">${displayAs}</a>`;
} else {
return ` <a href="http://man7.org/linux/man-pages/man${number}` +
return `<a href="http://man7.org/linux/man-pages/man${number}` +
`/${name}.${number}${optionalCharacter}.html">${displayAs}</a>`;
}
});
Expand Down