Skip to content

lib: migrate errors to internal/errors #17719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
styfle wants to merge 9 commits into from
Closed

lib: migrate errors to internal/errors #17719

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2fb022e
lib: migrate errors to internal/errors
styfle Dec 17, 2017
983f368
test: add check for stream._write() invalid type
styfle Dec 17, 2017
68a73c1
lib: fix error message
styfle Dec 18, 2017
c28d36c
test: fix error message
styfle Dec 18, 2017
a76b9f1
test: move test from syncwritestream to write-stream
styfle Dec 18, 2017
d01a120
test: add newline
styfle Dec 19, 2017
271e9b6
lib: change emit error to destroy
styfle Dec 19, 2017
b101fca
lib: fix typo in “destroy”
styfle Dec 20, 2017
67848eb
lib: change destroy back to emit error
styfle Dec 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: fix error message
  • Loading branch information
@styfle
styfle committed Dec 21, 2017
commit c28d36c7590ea3e8150fa69da2b66ba8de064bbe
3 changes: 1 addition & 2 deletions test/parallel/test-internal-fs-syncwritestream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,7 @@ const filename = path.join(common.tmpDir, 'sync-write-stream.txt');
}, {
code: 'ERR_INVALID_ARG_TYPE',
type: TypeError,
message: 'The "data" argument must be of type Buffer without null bytes.' +
' Received type number'
message: 'The "data" argument must be of type Buffer. Received type number'
});
}

Expand Down