Skip to content

http2: simplify onSelectPadding #17717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 2 commits into from
Closed

http2: simplify onSelectPadding #17717

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ee32f7
http2: simplify onSelectPadding
addaleax Dec 17, 2017
9e52c53
[squash] remove uint32 cast
addaleax Dec 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
http2: simplify onSelectPadding 
`OnCallbackPadding` on the native side already clamps
the return value into the right range, so there’s not need
to also do that on the JS side.

Also, use `>>> 0` instead of `| 0` to get an uint32, since
the communication with C++ land happens through an Uint32Array.
  • Loading branch information
@addaleax
addaleax committed Dec 17, 2017
commit 5ee32f7b2bf8c83584df6168c4ae0ab5a5221d41
5 changes: 1 addition & 4 deletions lib/internal/http2/core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,10 +354,7 @@ function onSelectPadding(fn) {
const frameLen = paddingBuffer[PADDING_BUF_FRAME_LENGTH];
const maxFramePayloadLen = paddingBuffer[PADDING_BUF_MAX_PAYLOAD_LENGTH];
paddingBuffer[PADDING_BUF_RETURN_VALUE] =
Math.min(maxFramePayloadLen,
Math.max(frameLen,
fn(frameLen,
maxFramePayloadLen) | 0));
fn(frameLen, maxFramePayloadLen) >>> 0;
Copy link
Copy Markdown
Member

@bnoordhuis bnoordhuis Dec 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The >>> 0 isn't necessary, is it? The assignment is going to coerce it to uint32 anyway.

Copy link
Copy Markdown
Member Author

@addaleax addaleax Dec 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bnoordhuis Yes. :) Updated!

};
}

Expand Down